RFR (M): 8219748: Add and use getter for the timing object in G1

Aleksey Shipilev shade at redhat.com
Wed Feb 27 10:36:01 UTC 2019


On 2/27/19 11:18 AM, Thomas Schatzl wrote:
> Hi,
> 
>   can I have reviews that adds a "phase_times()" getter to
> G1CollectedHeap to avoid the 50+ times of using "policy()-
>> phase_times()" instead?
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8219748
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8219748/webrev/

Looks good!

While you are at it, fix the indentation here?

2780   phase_times()->record_fast_reclaim_humongous_stats(time,
2781                                                                   cl.total_humongous(),
2782                                                                   cl.candidate_humongous());

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190227/08502b26/signature.asc>


More information about the hotspot-gc-dev mailing list