RFR (M): 8218880: G1 crashes when issuing a periodic GC while the GCLocker is held

Aleksey Shipilev shade at redhat.com
Wed Feb 27 10:50:47 UTC 2019


On 2/27/19 10:29 AM, Thomas Schatzl wrote:
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8218880
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8218880/webrev/

Nits:

*) "pause_succeeded" is a confusing name. "vmop_succeeded" adds to confusion. Maybe both locals and
the methods should be called "gc_succeeded"?

2151       vmop_succeeded = op.pause_succeeded();


*) I think burning here without backoff is not nice for the test, maybe sleep a little?

libTestPeriodicCollectionJNI.c:
  40     while (!release_critical) /* empty */;


Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190227/56d52910/signature.asc>


More information about the hotspot-gc-dev mailing list