RFR (M): 8219748: Add and use getter for the timing object in G1

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 27 11:59:24 UTC 2019


Hi,

On Wed, 2019-02-27 at 11:36 +0100, Aleksey Shipilev wrote:
> On 2/27/19 11:18 AM, Thomas Schatzl wrote:
> > Hi,
> > 
> >   can I have reviews that adds a "phase_times()" getter to
> > G1CollectedHeap to avoid the 50+ times of using "policy()-
> > > phase_times()" instead?
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8219748
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8219748/webrev/
> 
> Looks good!
> 
> While you are at it, fix the indentation here?
> 
> 2780   phase_times()->record_fast_reclaim_humongous_stats(time,
> 2781                                                                 
>   cl.total_humongous(),
> 2782                                                                 
>   cl.candidate_humongous());
> 
> -Aleksey
> 

  fixed in place (twice).

Thomas




More information about the hotspot-gc-dev mailing list