RFR (S): 8219369: Add named constants for iterating ExtRootScan phases

sangheon.kim at oracle.com sangheon.kim at oracle.com
Wed Feb 27 19:14:11 UTC 2019


Hi Thomas,

On 2/27/19 1:37 AM, Thomas Schatzl wrote:
> Hi,
>
> On Tue, 2019-02-26 at 17:49 -0500, Kim Barrett wrote:
>>> On Feb 20, 2019, at 5:15 AM, Thomas Schatzl <
>>> thomas.schatzl at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>>   can I have reviews for this change that has been suggested as part
>>> of another review to improve readability of the ExtRootScan sub-
>>> phase printing?
>>>
>> [...]
>>
>> Looks good, but...
>>
>> I have something of a preference against cluttering enums with such
>> pseudo-enumerators, and instead prefer class constants.  But I'll
>> leave it up to you.
>>
> Fixed in
> http://cr.openjdk.java.net/~tschatzl/8219369/webrev.0_to_1/ (diff)
> http://cr.openjdk.java.net/~tschatzl/8219369/webrev.1/ (full)
>
> Yeah, looks better. Thanks for making me look at this option.
Still looks good.

Thanks,
Sangheon


>
> Testing: compilation.
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list