RFR (S): 8219856: Spell out G1CollectorPolicy::is_hetero_heap

sangheon.kim at oracle.com sangheon.kim at oracle.com
Thu Feb 28 04:36:31 UTC 2019


Hi Thomas,

On 2/27/19 4:54 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this small change in naming of the method
> G1CollectorPolicy::is_hetero_heap() which includes the (to me) really
> uncommon abbreviation for heterogeneous as hetero?
>
> Every time I read this I ask myselves what this means in context of G1.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8219856
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8219856/webrev/
Looks good to me too.

Thanks,
Sangheon


> Testing:
> local compilation
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list