RFR (S): 8219369: Add named constants for iterating ExtRootScan phases

Thomas Schatzl thomas.schatzl at oracle.com
Thu Feb 28 09:28:15 UTC 2019


Hi Kim, Sangheon,

On Wed, 2019-02-27 at 12:23 -0500, Kim Barrett wrote:
> > On Feb 27, 2019, at 4:37 AM, Thomas Schatzl <
> > thomas.schatzl at oracle.com> wrote:
> > 
> > Hi,
> > 
[...]
> > > I have something of a preference against cluttering enums with
> > > such pseudo-enumerators, and instead prefer class constants.  But
> > > I'll leave it up to you.
> > > 
> > 
> > Fixed in
> > http://cr.openjdk.java.net/~tschatzl/8219369/webrev.0_to_1/ (diff)
> > http://cr.openjdk.java.net/~tschatzl/8219369/webrev.1/ (full)
> > 
> > Yeah, looks better. Thanks for making me look at this option.
> > 
> Looks good.
> 

On Wed, 2019-02-27 at 11:14 -0800, sangheon.kim at oracle.com wrote:
> Hi Thomas,
> 
> On 2/27/19 1:37 AM, Thomas Schatzl wrote:
> > Hi,
[...] 
> > Yeah, looks better. Thanks for making me look at this option.
> 
> Still looks good.
> 
> Thanks,
> Sangheon
> 

  thanks for your reviews.

Thomas



More information about the hotspot-gc-dev mailing list