RFR (M): 8218880: G1 crashes when issuing a periodic GC while the GCLocker is held

Kim Barrett kim.barrett at oracle.com
Thu Feb 28 20:48:04 UTC 2019


> On Feb 28, 2019, at 4:24 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi Kim,
> 
>  thanks for your review.
> 
> On Wed, 2019-02-27 at 17:19 -0500, Kim Barrett wrote:
>> At first I was thinking this seems very specific to the particular
>> bug at hand, and there is a need for something more general. But I've
>> decided I'm okay with this change as is, and leaving generalization
>> to the still-in-progress work on improving the whitebox control
>> mechanism.
> 
> Thanks. Please also consider that this change is supposed to be
> backported.

Good point.

>> So other than the possible name change, looks good.
>> 
> 
> New webrevs:
> 
> http://cr.openjdk.java.net/~tschatzl/8218880/webrev.1_to_2/ (diff)
> http://cr.openjdk.java.net/~tschatzl/8218880/webrev.2/ (full)
> 
> Thanks,
>  Thomas

Looks good.



More information about the hotspot-gc-dev mailing list