RFR (trivial): 8216285: Enable inlining of CollectedHeap::obj-/array-/class_allocate

Roman Kennke rkennke at redhat.com
Tue Jan 8 11:44:02 UTC 2019


>>>> Those methods are virtual. How useful is it to flag them 'inline' ?
>>>
>>> Useful enough to measurably save a few ns/op on Array.newInstance and
>>> Object.clone microbenchmarks (when running TieredStopAtLevel=1 to stay
>>> in the JNI slow path).
>>
>> If a method is virtual, it cannot be inlined, right? Unless you call it
>> in a funny non-virtual way. Or what am I missing?
> 
> Could be these are the only implementations when compiling without
> shenandoah so gcc realizes the virtual can be ignored?

I doubt that gcc can make that call. The linker probably could, but at
this point it would be too late. C++ is not Java. I don't think the
patch hurts, but I doubt its usefulness ;-)

Roman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190108/e1a51712/signature.asc>


More information about the hotspot-gc-dev mailing list