RFR (S) 8215724: Epsilon: ArrayStoreExceptionTest.java fails; missing arraycopy check

Leo Korinth leo.korinth at oracle.com
Tue Jan 8 17:30:52 UTC 2019


Hi Aleksey!

I guess you tried to use the already existing test 
(ArrayStoreExceptionTest.java) before you created the new test. What was 
the reason for not using it in the end? I would rather like that you 
tried to use the old test case, I believe it would improve overall 
testing and maintainability.

Also, there is a slight misleading comment on the #endif in 
barrierSet.inline.hpp, maybe instead use the style #endif // pragma once ;-)

   24 #ifndef SHARE_VM_GC_SHARED_BARRIERSET_INLINE_HPP
   25 #define SHARE_VM_GC_SHARED_BARRIERSET_INLINE_HPP
   60 #endif // SHARE_VM_GC_SHARED_BARRIERSET_HPP

Thanks,
Leo

Instead of using the existing

On 07/01/2019 19:19, Aleksey Shipilev wrote:
> Bug:
>    https://bugs.openjdk.java.net/browse/JDK-8215724
> 
> Fix:
>    http://cr.openjdk.java.net/~shade/8215724/webrev.01/
> 
> As mentioned in the bug, Epsilon deliberately reuses the super-class BarrierSet, thus implicitly
> verifying it does the sane thing. This is one of those cases where super-class BarrierSet does not
> checkcast, while it should.
> 
> Testing: Linux x86_64 fastdebug {new test, gc/epsilon, hotspot tier1}, jdk-submit (running)
> 
> Thanks,
> -Aleksey
> 


More information about the hotspot-gc-dev mailing list