RFR: 8216385: ZGC: Fix building without C2

Aleksey Shipilev shade at redhat.com
Tue Jan 8 20:40:56 UTC 2019


Just built it with "--with-debug-level=fastdebug --disable-precompiled-headers
--with-jvm-features=-compiler2", and it breaks:

/home/shade/jdk-jdk/src/hotspot/os_cpu/linux_x86/gc/z/zArguments_linux_x86.cpp:31:5: error:
"COMPILER2" is not defined [-Werror=undef]
 #if COMPILER2
     ^~~~~~~~~

It should be #ifdef, not #if...

-Aleksey

On 1/8/19 9:27 PM, Per Liden wrote:
> Ah, good point. It works anyway, but I will add that. I never use PCH.
> 
> Thanks!
> /Per
> 
> On 01/08/2019 09:22 PM, Aleksey Shipilev wrote:
>> One nit: util/macro.hpp should be included to gain access to COMPILER2, try without PCH?
>>
>> -Aleksey
>>
>> On 1/8/19 9:20 PM, Per Liden wrote:
>>> Thanks Aleksey!
>>>
>>> /Per
>>>
>>> On 01/08/2019 09:17 PM, Aleksey Shipilev wrote:
>>>> On 1/8/19 9:14 PM, Per Liden wrote:
>>>>> Building without C2 enabled (e.g. a client VM variant) fails after JDK-8215547, which introduced
>>>>> unconditional uses of "MaxVectorSize", a symbol only available when C2 is enabled.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8216385
>>>>> Webrev: http://cr.openjdk.java.net/~pliden/8216385/webrev.0
>>>>
>>>> Looks fine and trivial.
>>>>
>>>> -Aleksey
>>>>
>>
>>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190108/070419af/signature.asc>


More information about the hotspot-gc-dev mailing list