RFR 8215299: Remove G1CMTask::should_exit_termination()'s undesirable side-effect

Kim Barrett kim.barrett at oracle.com
Sat Jan 12 00:14:40 UTC 2019


> On Jan 10, 2019, at 12:22 PM, zgu at redhat.com wrote:
> 
> Hi Kim,
> 
> Thanks for the review. 
> 
> Please see updated webrev based on your suggestion:
> http://cr.openjdk.java.net/~zgu/JDK-8215299/webrev.03/index.html
> 
> 
>> Looks good, but I’d like to see more testing of something this
>> “core”, especially a bit of stress testing.
>> The submit tests are more at the level of “smoke” tests.
> 
> Besides submit tests, I also ran hotspot_gc tests on Linux 64, which
> contains stress tests.
> 
> This cycle, I also ran vmTestbase_vm_gc tests on Linux 64.
> 
> Thanks,
> 
> -Zhengyu
> 
>> 
>> Given that most callers of regular_clock_call now conditionally call
>> set_has_aborted, a helper function to encapsulate that might be nice.

Thanks for the additional testing.

------------------------------------------------------------------------------ 
src/hotspot/share/gc/g1/g1ConcurrentMark.hpp 
 733   // Set abort flag if above check fails

Rather than "above", actually refer to regular_clock_call by name.
I don't need to review again for this.

------------------------------------------------------------------------------ 
src/hotspot/share/gc/g1/g1ConcurrentMark.hpp 
 734   inline void abort_marking_if_regular_check_fail();

I'm not wild about this name, but don't have a better suggestion.
Maybe another reviewer will suggest something.  Otherwise, go
ahead with this name.

------------------------------------------------------------------------------

Looks good.



More information about the hotspot-gc-dev mailing list