RFR 8215299: Remove G1CMTask::should_exit_termination()'s undesirable side-effect

Roman Kennke rkennke at redhat.com
Tue Jan 15 15:38:16 UTC 2019


Hi Zhengyu, Kim,

>> -------------------------------------------------------------------
>> ----------- 
>> src/hotspot/share/gc/g1/g1ConcurrentMark.hpp 
>>  733   // Set abort flag if above check fails
>>
>> Rather than "above", actually refer to regular_clock_call by name.
>> I don't need to review again for this.
> 
> Will fix before push.
> 
> 
>> -------------------------------------------------------------------
>> ----------- 
>> src/hotspot/share/gc/g1/g1ConcurrentMark.hpp 
>>  734   inline void abort_marking_if_regular_check_fail();
>>
>> I'm not wild about this name, but don't have a better suggestion.
>> Maybe another reviewer will suggest something.  Otherwise, go
>> ahead with this name.
> 
> May I get a second review?

Looks ok to me. Thanks!

Roman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190115/28b5df72/signature.asc>


More information about the hotspot-gc-dev mailing list