RFR: JDK-8214236: sun.gc.collector.2.name should be changed

Per Liden per.liden at oracle.com
Wed Jan 16 08:55:46 UTC 2019


Hi,

On 1/15/19 4:30 PM, Chihiro Ito wrote:
> Hi Thomas and Per,
> 
> I fixed counter name in G1, CMS and Z.
> Could you review it ?
> 
> http://cr.openjdk.java.net/~cito/JDK-8214236/webrev.01/

Works for me. Just one comment. Please align the "ordinal" comment like 
this:

-    _collector_counters("stop-the-world" /* name */,
+    _collector_counters("Z concurrent cycle pauses" /* name */,
+                         2                          /* ordinal */) {}

/Per

> 
> 
> For your information, output of PerfCounter.print is following.
> 
> G1GC:
> sun.gc.collector.0.name="G1 incremental collection pauses"
> sun.gc.collector.1.name="G1 full collection pauses"
> sun.gc.collector.2.name="G1 concurrent cycle pauses"
> 
> CMS:
> sun.gc.collector.2.name="CMS concurrent cycle pauses"
> 
> ZGC:
> sun.gc.collector.2.name="Z concurrent cycle pauses"
> 
> Regards,
> Chihiro
> 
> On 2019/01/15 18:49, Thomas Schatzl wrote:
>> Hi Chihiro,
>>
>> On Tue, 2019-01-15 at 02:19 +0900, Chihiro Ito wrote:
>>> Hi,
>>>
>>> Thank you for reviewing and giving ideas.
>>>
>>> I agree to this idea. In addition, I think we should change also
>>> counter  names "CMS stop-the-world phases" to  "CMS concurrent cycle
>>> pauses" in CMS.
>>    fine with me.
>>
>> Thomas
>>
>>
>>
> 


More information about the hotspot-gc-dev mailing list