RFR 8215299: Remove G1CMTask::should_exit_termination()'s undesirable side-effect

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jan 16 16:09:53 UTC 2019


Hi,

On Mon, 2019-01-14 at 08:21 -0500, zgu at redhat.com wrote:
> Thanks again, Kim.
> 
> > > > 
> > 
> > -------------------------------------------------------------------
> > ----------- 
> > src/hotspot/share/gc/g1/g1ConcurrentMark.hpp 
> >  733   // Set abort flag if above check fails
> > 
> > Rather than "above", actually refer to regular_clock_call by name.
> > I don't need to review again for this.
> 
> Will fix before push.
> 
> 
> > -------------------------------------------------------------------
> > ----------- 
> > src/hotspot/share/gc/g1/g1ConcurrentMark.hpp 
> >  734   inline void abort_marking_if_regular_check_fail();
> > 
> > I'm not wild about this name, but don't have a better suggestion.
> > Maybe another reviewer will suggest something.  Otherwise, go
> > ahead with this name.

My suggestion would be something like
"abort_marking_if_regular_clock_call_fails()" which does not make it
shorter. It is only a weak suggestion too, so feel free to keep or
change it without the need of a re-review.

> 
> May I get a second review?

Now the third - looks good.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list