RFR (S) 8217014: Epsilon should not ignore Metadata GC causes

Aleksey Shipilev shade at redhat.com
Wed Jan 16 20:59:59 UTC 2019


Hi,

On 1/16/19 9:34 PM, Thomas Stüfe wrote:
> looks good.

Thanks!

> In your test you could set the initial metaspace size to a small size too for added effect, this
> triggers a lot of resizing early on (eg -XX:MetaspaceSize=1m).

Right. I was trying to achieve the same by setting Initial*, but MetaspaceSize is sure better.

> nit: EpsilonHeap::print_metaspace_info(): I assume this cannot be called before metaspace is set up.
> Still, would prefer checking for reserved=0 before printing the percentages.

Nice catch. Checked for zero in both heap and metaspace cases. Also turned both methods private, so
we control when they are called from within.

New webrev:
  http://cr.openjdk.java.net/~shade/8217014/webrev.02/

Thanks,
-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190116/bbf2b3b8/signature.asc>


More information about the hotspot-gc-dev mailing list