RFR(XXS) 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 17 09:33:42 UTC 2019


Hi,

On Wed, 2019-01-16 at 11:15 -0500, zgu at redhat.com wrote:
> Please review this cleanup that removes include of .inline.hpp in
> shenandoahTaskQueue.hpp, updates includes in related files that are
> impacted by the cleanup, and minor style changes.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8217213
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217213/webrev.00/
> 
> Test:
>   PCH and none PCH builds on Linux x64
>   tier1, 2, 3 gc_shenandoah on Linux x64
> 

 minor nit:

shenandoahVerifier.cpp contains both shenandoahHeap.inline.hpp and
shenandoahHeap.hpp.

No need to re-review if you intend to do something about this.

Looks good otherwise.

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list