RFR(S): 8215934: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jan 17 10:12:38 UTC 2019


Hi,

On Wed, 2019-01-09 at 20:41 +0000, Hohensee, Paul wrote:
> Thomas reviewed the CSR, so I’ve put it into Finalized state. Thanks
> Thomas.
>  
> Please review the backport.
>  
> Bug: https://bugs.openjdk.java.net/browse/JDK-8215934
> Webrev: http://cr.openjdk.java.net/~phh/8215934/webrev.00/
>  

one nit: I do not completely understand the "  30  * @requires
vm.opt.MaxGCPauseMillis == "null"" in TestOldGenCollectionUsage.java as
the test itself runs in othervm mode anyway.

(The vm.gc=="G1" | vm.gc=="null" has traditionally been used to limit
the number of invocations of this test, i.e. to not get repeats when
running all tests with all collectors. But then the test is in the g1
subdirectory anyway).

The MaxGCPauseMillis @requires does not hurt, but seems to serve no
real purpose.

Looks good.

Thomas





More information about the hotspot-gc-dev mailing list