RFR: 8217325: Enable inlining of java_lang_Class::oop_size_raw

Aleksey Shipilev shade at redhat.com
Thu Jan 17 17:23:38 UTC 2019


On 1/17/19 6:12 PM, Claes Redestad wrote:
> Hi,
> 
> InstanceMirrorKlass::oop_size could be helped slightly if
> java_lang_Class::oop_size_raw was made inlineable.
> 
> This significantly speeds up one branch in oopDesc::size_given_klass
> (heavily used by G1, at least during startup/warmup) while not causing
> any increase in binary size (linux x64).
> 
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8217325
> Webrev: http://cr.openjdk.java.net/~redestad/8217325/open.00/

Looks good.

I remember seeing the profiles for Shenandoah that walks the objects and uses oopDesc::size*
heavily, and it was inlined in product builds. That said, inlining it manually does not hurt.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190117/5d3c3571/signature.asc>


More information about the hotspot-gc-dev mailing list