RFR: 8212826: Make PtrQueue free list lock-free - Build error in gtest

Langer, Christoph christoph.langer at sap.com
Sun Jan 20 14:08:25 UTC 2019


Hi Kim,

in my build on Windows I now get this:
c:/mercurial/jdk/test/hotspot/gtest/utilities/test_lockFreeStack.cpp(54): error C2921: redefinition: 'Stack': class template is being redeclared as 'typedef LockFreeStackTestElement::Stack Stack'
c:\mercurial\jdk\src\hotspot\share\utilities/stack.hpp(93): note: see declaration of 'Stack'
Seems like there's a conflict.

Are you aware of that? Is there already a bug open for this?

Thank you
Christoph


> -----Original Message-----
> From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> On
> Behalf Of Kim Barrett
> Sent: Sonntag, 20. Januar 2019 00:44
> To: sangheon.kim at oracle.com
> Cc: hotspot-gc-dev at openjdk.java.net
> Subject: Re: RFR: 8212826: Make PtrQueue free list lock-free
> 
> > On Jan 19, 2019, at 2:26 AM, sangheon.kim at oracle.com wrote:
> >>
> >> New webrevs:
> >> full: http://cr.openjdk.java.net/~kbarrett/8212826/open.01/
> >> incr: http://cr.openjdk.java.net/~kbarrett/8212826/open.01.inc/
> > 01 looks good.
> 
> Thanks.
> 
> > FYI, 4 files failed(ptrQueue.hpp, logTag.hpp padded.hpp mutexLocker.hpp)
> to apply because the copyright year is already updated.
> > Actual codes were applied cleanly. I don't need a webrev for this change.
> 
> Yeah.  I should get one of those copyright updater scripts various people use,
> so I can deal with it just before pushing.
> Of course, this year there will be much less of a need for updates, since
> Coleen has already touched most .hpp files.



More information about the hotspot-gc-dev mailing list