RFR (S) 8217423: Windows gtest build fails after JDK-8212826 (Make PtrQueue free list lock-free)

Kim Barrett kim.barrett at oracle.com
Mon Jan 21 01:31:53 UTC 2019


> On Jan 20, 2019, at 3:39 PM, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> Bug:
>  https://bugs.openjdk.java.net/browse/JDK-8217423
> 
> Fix:
>  http://cr.openjdk.java.net/~shade/8217423/webrev.01/
> 
> Current Windows build is broken. This patch fixes it by renaming the test typedef to resolve the
> name conflict with the actual Stack. I suspect that definition comes via precompiled.hpp, but
> regardless, including stack.hpp accidentally should not break the test. Let's instead use the
> special name for test typedef.
> 
> Testing: {Linux, Windows} x86_64 build, gtest; jdk-submit (running)
> 
> Thanks,
> -Aleksey

Looks good.



More information about the hotspot-gc-dev mailing list