RFR (L): 8213229: Investigate treating StringTable as weak in young collections

Zhengyu Gu zgu at redhat.com
Tue Jan 22 15:22:35 UTC 2019


Hi Thomas,

Shenandoah part looks good to me.

Nits:

*) weakProcessor.inline.hpp Line #52 indent

*) weakProcessor.cpp includes both .hpp and .inline.hpp

Thanks,

-Zhengyu

On 1/22/19 5:02 AM, Thomas Schatzl wrote:
> Hi all,
> 
> On Sat, 2019-01-12 at 04:52 -0500, Kim Barrett wrote:
>>> On Jan 11, 2019, at 9:51 PM, Kim Barrett <kim.barrett at oracle.com>
>>> wrote:
>>>
>>>> On Jan 10, 2019, at 3:46 PM, Thomas Schatzl <
>>>> thomas.schatzl at oracle.com> wrote:
>>>> […]
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8213229
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tschatzl/8213229/webrev.1/
>>>> Testing:
>>>> hs-tier1-6, performance checking with our performance suite
>>>> showed no particular performance differences before/after
> 
> Updated webrev at
> 
> http://cr.openjdk.java.net/~tschatzl/8213229/webrev.1_to_2 (diff)
> http://cr.openjdk.java.net/~tschatzl/8213229/webrev.2/ (full)
> 
> implementing the notification of the ServiceThread and applying Kim's
> naming suggestion.
> 
> Thanks,
>    Thomas
> 
> 


More information about the hotspot-gc-dev mailing list