RFR(XXS) 8217522: Missing barriers in some java_lang_String assertion code after JDK-8213229

Aleksey Shipilev shade at redhat.com
Tue Jan 22 20:58:30 UTC 2019


On 1/22/19 9:52 PM, Zhengyu Gu wrote:
> Although the changes are in shared code, but they only affect Shenandoah.
> 
> Once JDK-8213229 pushed, we need this patch to unbreak Shenandoah tests. The root cause, after
> JDK-8213229, is that references in stringtable are updated concurrently, instead of at safepoints.

Ah, dang. I suggested oopDesc::equals_raw to Claes, hoping that would be enough. Yes, stronger
oopDesc::equals is preferred. It is mildly irritating those can be different copies of the object,
though, but it is safe because we are only reading from them.

Looks good!

-Aleksey



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190122/c9be99df/signature.asc>


More information about the hotspot-gc-dev mailing list