RFR(XXS) 8217522: Missing barriers in some java_lang_String assertion code after JDK-8213229

Zhengyu Gu zgu at redhat.com
Tue Jan 22 21:00:32 UTC 2019



On 1/22/19 3:58 PM, Aleksey Shipilev wrote:
> On 1/22/19 9:52 PM, Zhengyu Gu wrote:
>> Although the changes are in shared code, but they only affect Shenandoah.
>>
>> Once JDK-8213229 pushed, we need this patch to unbreak Shenandoah tests. The root cause, after
>> JDK-8213229, is that references in stringtable are updated concurrently, instead of at safepoints.
> 
> Ah, dang. I suggested oopDesc::equals_raw to Claes, hoping that would be enough. Yes, stronger
> oopDesc::equals is preferred. It is mildly irritating those can be different copies of the object,
> though, but it is safe because we are only reading from them.

I noticed that, his final patch does not have oopDesc::equals_raw ...

Thanks,

-Zhengyu


> 
> Looks good!
> 
> -Aleksey
> 
> 
> 


More information about the hotspot-gc-dev mailing list