RFR: 8214799: Add package declaration to each JTREG test case in the gc folder

Thomas Schatzl thomas.schatzl at oracle.com
Wed Jan 23 09:51:54 UTC 2019


Hi,

On Thu, 2019-01-17 at 16:58 +0100, Leo Korinth wrote:
> Hi,
> 
> I have added package name to newly added
> TestPeriodicLogMessages.java.
> 
> I would be happy for a review from a reviewer (for the whole change,
> not 
> only this test).
> 
> The updated test case has been tested.

Good change to decrease the threshold to improve these :)

.02 changes and below diff look good.

Thomas

> 
> /Leo
> 
> 
> diff --git a/test/hotspot/jtreg/gc/g1/TestPeriodicLogMessages.java 
> b/test/hotspot/jtreg/gc/g1/TestPeriodicLogMessages.java
> index 2cede583c45..bd02a6e1c0a 100644
> --- a/test/hotspot/jtreg/gc/g1/TestPeriodicLogMessages.java
> +++ b/test/hotspot/jtreg/gc/g1/TestPeriodicLogMessages.java
> @@ -21,6 +21,8 @@
>    * questions.
>    */
> 
> +package gc.g1;
> +
>   /**
>    * @test TestPeriodicLogMessages
>    * @bug 8216490
> @@ -29,6 +31,7 @@
>    * @library /test/lib /
>    * @modules java.base/jdk.internal.misc
>    * @modules java.management/sun.management
> + * @run main gc.g1.TestPeriodicLogMessages
>    */
> 
>   import jdk.test.lib.process.OutputAnalyzer;
> 



More information about the hotspot-gc-dev mailing list