RFR 8215047: Task terminators do not complete termination in consistent state

zgu at redhat.com zgu at redhat.com
Wed Jan 23 14:32:45 UTC 2019


Hi Thomas,

Thanks for getting the review started.


> initial comments:
> 
> - taskqueue.hpp: I recommend adding an empty virtual destructor in
> any
> case.
> 
> - owstTaskTerminator.cpp:69: s/returnning/returning/
> 
Updated based on your comments:

http://cr.openjdk.java.net/~zgu/JDK-8215047/webrev.01/index.html

Thanks,

-Zhengyu

> I will think a bit more about the change while waiting for the test
> results.
> 



> Thanks,
>   Thomas
> 


More information about the hotspot-gc-dev mailing list