RFR (L): 8217330: Split CollectionSetChooser into collection set candidate container and the chooser algorithm

Leo Korinth leo.korinth at oracle.com
Thu Jan 24 18:04:37 UTC 2019


Hi Thomas.

I think this looks really good, thanks for cleaning this up. Keep in 
mind my lack of experience.

Minor nits: you need to update copyright years. There is an extra 
(unnecessary) line "bool this_pause_was_last_before_mixed = 
collector_state()->in_young_gc_before_mixed();" that can be removed.

Thanks,
Leo

On 21/01/2019 12:35, Thomas Schatzl wrote:
> Hi all,
> 
>    can I have reviews for this cleanup change that splits
> CollectionSetChooser into the container holding the collection set
> candidates (named G1CollectionSetCandidates) and the
> CollectionSetChooser (will be renamed in JDK-8217328) that only
> contains static methods to create the candidate set?
> 
> I think this improves readability of the code a lot given this
> misnomer.
> 
> Finally it removes some really ugly constructor hack (sorry D.
> Detlefs!) with GrowableArray.
> 
> (It actually, if you remove new file headers, reduces code size a bit
> too)
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8217330
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8217330/webrev/
> Testing:
> hs-tier1-5
> 
> Thanks,
>    Thomas
> 


More information about the hotspot-gc-dev mailing list