RFR (L): 8217330: Split CollectionSetChooser into collection set candidate container and the chooser algorithm

Thomas Schatzl thomas.schatzl at oracle.com
Fri Jan 25 14:11:23 UTC 2019


Hi Leo,

On Thu, 2019-01-24 at 19:04 +0100, Leo Korinth wrote:
> Hi Thomas.
> 
> I think this looks really good, thanks for cleaning this up. Keep in 
> mind my lack of experience.
> 
> Minor nits: you need to update copyright years. There is an extra 
> (unnecessary) line "bool this_pause_was_last_before_mixed = 
> collector_state()->in_young_gc_before_mixed();" that can be removed.

  thanks for your review.

All fixed in
http://cr.openjdk.java.net/~tschatzl/8217330/webrev.0_to_1 (diff)
http://cr.openjdk.java.net/~tschatzl/8217330/webrev.1 (full)

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list