RFR (S)[12]: 8217666: gc/nvdimm/* should not be included any tiers

Leo Korinth leo.korinth at oracle.com
Mon Jan 28 10:25:52 UTC 2019


Hi Sangheon,

a few questions on the webrev:
1) what does the added vm.nvdimm.test.enabled line in TEST.ROOT do?
2) most of the *Enabled() functions in VMProps.java read properties, but 
here we read the environment, why is that?
3) maybe the property should be "vm.gc" prefixed instead of "vm" 
prefixed, maybe not. What do you think?

Thanks for disabling these test cases!
/Leo

On 26/01/2019 16:35, sangheon.kim at oracle.com wrote:
> Hi all,
> 
> Can I have reviews that excludes gc/nvdimm jtreg tests?
> 
> Those tests were introduced by  JDK-8202286 (Allocation of old 
> generation of Java heap on alternate memory devices) and tried to 
> exclude all tests from all tiers. But it was incomplete so one of the 
> tests failed and JDK-8217406 (gc/nvdimm/TestOldObjectsOnNvdimm.java 
> failure) was filed recently.
> 
> The patch includes to exclude gc/nvdimm from TEST.groups, hotspot_misc 
> group(which is the reason why JDK-8217406 occurred). In addition, added 
> @requires to gc/nvdimm tests to avoid running the tests.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8217666
> webrev: http://cr.openjdk.java.net/~sangheki/8217666/webrev.0/
> Testing: manual tests w/, w/o VM_NVDIMM_TEST environmental variable.
> 
> Thanks,
> Sangheon


More information about the hotspot-gc-dev mailing list