RFR(XXS) 8217794: Improve termination detection in owstTaskTerminator

zgu at redhat.com zgu at redhat.com
Mon Jan 28 15:13:55 UTC 2019


Thanks for reviewing and additional info.

-Zhengyu
 

On Mon, 2019-01-28 at 16:04 +0100, Thomas Schatzl wrote:
> Hi,
> 
> On Mon, 2019-01-28 at 09:56 -0500, zgu at redhat.com wrote:
> > Hi,
> > 
> > Could I get review for this small enhancement, that may improve
> > termination dectection?
> > 
> > This is *not* a correctness issue, but latency improvement. Since
> > it
> > already holds lock, it is worth a quick check for termination
> > condition.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8217794
> > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217794/webrev.00/
> > 
> > Test:
> >   hotspot_gc on Linux x64 (fastdebug and release)
> >   Submit tests
> 
>   looks good.
> 
> Fyi (for other reviewers) I tested (and reviewed) this change already
> as part of some early version of JDK-8215047.
> 
> Thanks,
>   Thomas
> 
> 


More information about the hotspot-gc-dev mailing list