RFR (M): 8217778: StringTable cleanup miscalculates amount of dead objects

Kim Barrett kim.barrett at oracle.com
Tue Jan 29 03:58:35 UTC 2019


> On Jan 28, 2019, at 10:24 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8217778
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8217778/webrev/
>> Testing:
>> hs-tier1-5
>> 
>> Thanks,
>> Thomas
> 
> Looks good.
> 
> A couple minor cleanup suggestions.  I don't need another webrev if
> you decide to do these.
> 

Sorry, I missed this:

------------------------------------------------------------------------------
src/hotspot/share/gc/shared/weakProcessor.cpp
  44       CountingSkippedIsAliveClosure<BoolObjectClosure, OopClosure> cl(is_alive, keep_alive);

A different approach is possible in this serial case.  We could wrap
the keep_alive closure for counting, as the number we want to pass to
inc_dead_counter is also available here as

  storage->allocation_count() - <number of keep_alive calls>

------------------------------------------------------------------------------





More information about the hotspot-gc-dev mailing list