RFR (L): 8213229: Investigate treating StringTable as weak in young collections

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jan 29 09:34:13 UTC 2019


Hi Kim,

On Mon, 2019-01-28 at 21:39 -0500, Kim Barrett wrote:
> > On Jan 24, 2019, at 7:55 AM, Thomas Schatzl <
> > thomas.schatzl at oracle.com> wrote:
> > On Wed, 2019-01-23 at 23:07 -0500, Kim Barrett wrote:
> > > 
> > > 
[...]
> > > src/hotspot/share/gc/g1/g1CollectedHeap.cpp
> > > 3397     // Ideally we would use a StringDedupCleaningTask here,
> > > but since we want to
> > > 3398     // take the time we need to copy the code here.
> > > 
> > > Maybe s/take the time/record the time/ ?
> > > 
> > > I found the current wording confusing.
> > 
> > 
> [...]
>
> I understood that.  It was just the comment wording that gave me
> trouble.
> “take the time” := use time or expend effort.

Oooh, thanks!

[...]
> 
> > New webrevs at:
> > http://cr.openjdk.java.net/~tschatzl/8213229/webrev.2_to_3/ (diff)
> > http://cr.openjdk.java.net/~tschatzl/8213229/webrev.3/ (full)
> > Testing:
> > locally running gc/g1, started hs-tier1-5
> 
> Looks good.
> 
> One very minor formatting nit, for which I don’t need a new webrev.
> 
> -------------------------------------------------------------------
> -----------
> src/hotspot/share/gc/g1/g1CollectedHeap.hpp
> 1336   void string_dedup_cleaning(BoolObjectClosure* is_alive,
> 1337                         OopClosure* keep_alive,
> 1338                         G1GCPhaseTimes* phase_times = NULL);
> Second and third parameters are not indented consistently with other
> code; should be aligned with the first parameter.
> 
> -------------------------------------------------------------------
> -----------
> 

Fixed. Thanks for your review.

Thomas



More information about the hotspot-gc-dev mailing list