RFR (XS): 8220345: Use appropriate type for G1RemSetScanState::IsDirtyRegionState

Leo Korinth leo.korinth at oracle.com
Fri Mar 8 17:24:43 UTC 2019


Change looks good to me.

Thanks,
Leo

On 08/03/2019 14:51, Thomas Schatzl wrote:
> Hi all,
> 
>    can I have reviews for this small change that removes the use of
> jbyte for an internal data type in favor of the initially intended bool
> ?
> 
> The original reason to do so was "G1RemSetScanState::IsDirtyRegionState
> is a jbyte because "since there are no atomic instructions for
> bools".", but this is obviously no longer true, and the workaround can
> be removed.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8220345
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8220345/webrev/
> Testing:
> hs-tier1-5
> 
> Thanks,
>    Thomas
> 
> 


More information about the hotspot-gc-dev mailing list