RFR: 8220294: ZGC fails to build on GCC 4.4.7: Type parameter issue

Per Liden per.liden at oracle.com
Tue Mar 12 11:28:32 UTC 2019


On 3/11/19 3:59 PM, Aleksey Shipilev wrote:
> On 3/11/19 10:00 AM, Severin Gehwolf wrote:
>> On Fri, 2019-03-08 at 18:27 +0100, Aleksey Shipilev wrote:
>>> On 3/8/19 3:04 PM, Severin Gehwolf wrote:
>>>> Could I please get reviews for this build fix for ZGC. GCC 4.4.7 seems
>>>> to get confused which constructor it should use for ZStatSampler,
>>>> ZStatCounter and ZStatUnsampledCounter. Specifying the template type T
>>>> for ZStatIterableValue for each of them in the initializer list fixes
>>>> it.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8220294
>>>> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220294/01/webrev/
>>>
>>> Lookg good to me.
>>
>> Thanks for the review, Aleksey! Do I need another review for this?
> 
> This _looks_ trivial, but I'd like ZGC folks to take a brief look at it.
> 

Looks good.

/Per


More information about the hotspot-gc-dev mailing list