RFR: 8220496: Race in java_lang_String::length() when deduplicating

Per Liden per.liden at oracle.com
Wed Mar 13 12:55:39 UTC 2019


Hi,

On 3/12/19 1:46 PM, Claes Redestad wrote:
> Hi,
> 
> a few asserts in java_lang_String can trigger when deduplicating
> Strings. The fix is to ensure we assert using a deeper equals on the
> contents of the value.  Moving the method already implemented to do this
> in StringDedupTable to java_lang_String seems to be in order, along with
> a few cleanups.
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8220496/open.00/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8220496

Looks good. Just one minor nit, can we call it "value_equals" instead of 
"values_equal", to better match the the existing "equals" functions?

I don't need to see a new webrev.

cheers,
Per

> 
> Testing: tier1-3
> 
> Thanks!
> 
> /Claes


More information about the hotspot-gc-dev mailing list