RFR(T) : 8220727 : put ArraySize an InfiniteList into zgc problem list

jesper.wilhelmsson at oracle.com jesper.wilhelmsson at oracle.com
Fri Mar 15 17:56:48 UTC 2019


Both tests passes with this change.
Thanks for the review!
/Jesper

> On 15 Mar 2019, at 18:45, Igor Ignatev <igor.ignatyev at oracle.com> wrote:
> 
> If the tests work w/ zGC now, then the fix looks good to me.
> 
> — Igor
> 
>> On Mar 15, 2019, at 10:38 AM, jesper.wilhelmsson at oracle.com wrote:
>> 
>> I f this is the correct fix I can push it immediately. Please review asap.
>> 
>> 
>> diff --git a/test/hotspot/jtreg/gc/ArraySize.java b/test/hotspot/jtreg/gc/ArraySize.java
>> --- a/test/hotspot/jtreg/gc/ArraySize.java
>> +++ b/test/hotspot/jtreg/gc/ArraySize.java
>> @@ -25,7 +25,7 @@
>> * @test
>> * @bug 4063078
>> * @summary Allocating a ridiculously large array should not crash the VM
>> - * @run main/othervm -Xmx32m -Xms32m gc.ArraySize
>> + * @run main/othervm -Xmx128m -Xms32m gc.ArraySize
>> */
>> 
>> package gc;
>> diff --git a/test/hotspot/jtreg/gc/InfiniteList.java b/test/hotspot/jtreg/gc/InfiniteList.java
>> --- a/test/hotspot/jtreg/gc/InfiniteList.java
>> +++ b/test/hotspot/jtreg/gc/InfiniteList.java
>> @@ -26,7 +26,7 @@
>> * @bug 4098578
>> * @summary Check if the VM properly throws OutOfMemoryError
>> * @author Sheng Liang
>> - * @run main/othervm -Xmx25M gc.InfiniteList
>> + * @run main/othervm -Xmx128m gc.InfiniteList
>> */
>> 
>> package gc;
>> 
>> 
>> Thanks,
>> /Jesper
>> 
>> 
>>> On 15 Mar 2019, at 18:16, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>> 
>>> On 2019-03-15 17:44, Igor Ignatev wrote:
>>>> Hi Stefan,
>>>> Frankly I haven’t looked much into it, and decided to go w/ problem listing to quickly remove noise from test results. If you have a proper fix ready, please go ahead w/ it, I’ll withdraw this RFR.
>>> 
>>> I'm on my way home, and the proper fix is what I suggested below. I'll leave it up to you to decide how to deal with this change.
>>> 
>>> StefanK
>>> 
>>>> I won’t be able to come back to this till 1pm PT.
>>>> — Igor
>>>>> On Mar 15, 2019, at 9:29 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>>>> 
>>>>> Hi Igor,
>>>>> 
>>>>> I think this could easily be fixed by changing the heap size to -Xmx128m. There's no need to problem list these tests, IMHO.
>>>>> 
>>>>> However, if you still want to problem list the tests, then this looks good.
>>>>> 
>>>>> Thanks,
>>>>> StefanK
>>>>> 
>>>>>>> On 2019-03-15 17:23, Igor Ignatyev wrote:
>>>>>>> http://cr.openjdk.java.net/~iignatyev//8220727/webrev.00
>>>>>>> 3 lines changed: 3 ins; 0 del; 0 mod;
>>>>>> Hi all,
>>>>>> could you please review the trivial patch which put ArraySize an InfiniteList tests into zgc problem list?
>>>>>> webrev: http://cr.openjdk.java.net/~iignatyev//8220727/webrev.00
>>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8220727
>>>>>> Thanks,
>>>>>> -- Igor
>> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190315/569e1305/signature.asc>


More information about the hotspot-gc-dev mailing list