RFR: 8220610: Make CollectedHeap nmethod functions pure virtual

Stefan Karlsson stefan.karlsson at oracle.com
Mon Mar 18 15:44:26 UTC 2019


On 2019-03-18 16:32, Aleksey Shipilev wrote:
> On 3/18/19 4:26 PM, Stefan Karlsson wrote:
>> Hi all,
>>
>> I suggest that we make all CollectedHeap nmethod functions pure virtual.
>>
>> http://cr.openjdk.java.net/~stefank/8220610/webrev.01/
> 
> Epsilon changes are trivially fine.
> 
> Shenandoah changes look fine. I assume flush_nmethod is only need when GC implementation actually
> uses CompiledMethod::gc_data storage attached to nmethod*, and not otherwise?

Thanks for looking this.

Yes, that's correct. It's a callback to be able to delete the associated 
gc data.

We've been thinking about maybe renaming nmethod::flush and 
CollectedHeap::flush_nmethod, to something more descriptive, and / or 
align the names with other metadata lifecycle names.

StefanK

> 
> -Aleksey
> 


More information about the hotspot-gc-dev mailing list