[URGENT] RFR (XS) 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue)

Kim Barrett kim.barrett at oracle.com
Sat Mar 23 20:48:14 UTC 2019


> On Mar 23, 2019, at 5:53 AM, Aleksey Shipilev <shade at redhat.com> wrote:
> 
> Bug:
>  https://bugs.openjdk.java.net/browse/JDK-8221363
> 
> Super-class SATBMarkQueue dropped this:
> 
> -SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset, bool permanent) :
> +SATBMarkQueue::SATBMarkQueue(SATBMarkQueueSet* qset) :
> 
> So the build fix is:
> 
> diff -r c81fbf340ceb src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp
> @@ -29,11 +29,11 @@
> #include "runtime/mutex.hpp"
> #include "runtime/thread.hpp"
> 
> class ShenandoahSATBMarkQueue: public SATBMarkQueue {
> public:
> -  ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset, /* permanent = */ false) {}
> +  ShenandoahSATBMarkQueue(SATBMarkQueueSet* qset) : SATBMarkQueue(qset) {}
>   virtual bool should_enqueue_buffer();
> };
> 
> class ShenandoahSATBMarkQueueSet : public SATBMarkQueueSet {
> private:
> 
> 
> Testing: local Linux x86_64 build
> 
> -Aleksey

Looks good.  (I see you’ve already pushed.)

Sorry about that; I thought I’d updated Shenandoah too, but obviously missed this.



More information about the hotspot-gc-dev mailing list