RFR: JDK-8220671: Initialization race for non-JavaThread PtrQueues

Roman Kennke rkennke at redhat.com
Mon Mar 25 20:21:46 UTC 2019


>>
>> This thread went a bit off. May I propose this for review:
>>
>> http://cr.openjdk.java.net/~rkennke/JDK-8220671/webrev.07/
>>
>> it passes tier1 tests locally, and I submitted it to jdk/submit but that seems to have other hiccups.
>>
>> WDYT?
> 
> I'm still not convinced the activation predicates for the STS joiners
> are correct here.  And I'm not what the right predicate might be or if
> it even exists.
> 
> Also, STS is presently a "GC" thing, and this would insinuate it into
> non-GC code, and affect non-GC threads (such as the WatcherThread and
> the JfrThreadSampler).
> 
> I still prefer using the NonJavaThreadsList_lock in NJT::pre/post_run
> and around the the relevant state changes, such as setting the SATB
> qset's _all_active member.

Right. I need to try it again. Back when I tried it, I could not verify
that it indeed fixes the problem, because of other bugs. Let me try both
your patches for this and the thread claiming issue and see if that
fixes my testcase.

Roman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20190325/612127a8/signature.asc>


More information about the hotspot-gc-dev mailing list