RFR: 8232686: Turn parallel gc develop tracing flags into unified logging

Leo Korinth leo.korinth at oracle.com
Wed Feb 12 08:12:48 UTC 2020


Hi Ivan,

On 11/02/2020 11:47, Ivan Walulya wrote:
> Thanks Stefan, find below patch with the suggested updates.
> 
> http://cr.openjdk.java.net/~sjohanss/iwalulya/8232686/00-01/ <http://cr.openjdk.java.net/~sjohanss/iwalulya/8232686/00-01/>
> 
> http://cr.openjdk.java.net/~sjohanss/iwalulya/8232686/01/ <http://cr.openjdk.java.net/~sjohanss/iwalulya/8232686/01/>


Looks good, I will help you push it.

Thanks,
Leo


> 
> //Ivan
> 
>> On 11 Feb 2020, at 11:26, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>>
>> H Ivan,
>>
>>> 11 feb. 2020 kl. 08:34 skrev Ivan Walulya <ivan.walulya at oracle.com>:
>>>
>>> Hi all,
>>>
>>> Please review a small modification to  turn parallel gc develop tracing flags into unified logging
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232686 <https://bugs.openjdk.java.net/browse/JDK-8232686>
>>> Webrev: http://cr.openjdk.java.net/~sjohanss/iwalulya/8232686/00/ <http://cr.openjdk.java.net/~sjohanss/iwalulya/8232686/00/>
>>>
>> When looking through the webrev again I realized that we can now remove the "#ifdef ASSERT” here:
>> 1616 #ifdef  ASSERT
>> 1617   log_develop_debug(gc, marking)(
>> 1618       "add_obj_count=" SIZE_FORMAT " "
>> 1619       "add_obj_bytes=" SIZE_FORMAT,
>> 1620       add_obj_count,
>> 1621       add_obj_size * HeapWordSize);
>> 1622   log_develop_debug(gc, marking)(
>> 1623       "mark_bitmap_count=" SIZE_FORMAT " "
>> 1624       "mark_bitmap_bytes=" SIZE_FORMAT,
>> 1625       mark_bitmap_count,
>> 1626       mark_bitmap_size * HeapWordSize);
>> 1627 #endif  // #ifdef ASSERT
>>
>> Otherwise a very nice cleanup.
>>
>> Thanks,
>> Stefan
>>
>>> Testing: Tier 1 - Tier 3
>>>
>>> //Ivan
>>
> 


More information about the hotspot-gc-dev mailing list