RFR: JDK-8237780: Shenandoah: More reliable nmethod verification

Zhengyu Gu zgu at redhat.com
Mon Feb 17 14:03:28 UTC 2020



On 2/17/20 7:34 AM, Roman Kennke wrote:
>>> http://cr.openjdk.java.net/~rkennke/JDK-8237780/webrev.01/
>>
>> This is fine.
>>
>> Although I would probably be open for storing that diagnostics into stringStream (see how
>> ShenandoahAsserts::print_failure does it), and putting it into the fatal message itself. Pros:
>> customers would hand over hs_errs to us with the relevant diagnostics. Cons: we can overflow the
>> stringStream and truncate parts of the data. Your call.
> 
> 
> Ok, let's do that then:
> 
> http://cr.openjdk.java.net/~rkennke/JDK-8237780/webrev.02/
> 
> Good?

assert_same_oops() itself is assert only (has NOT_DEBUG_RETURN in 
definition), does not need nested ifdef ASSERT ...

-Zhengyu


> 
> Roman
> 



More information about the hotspot-gc-dev mailing list