From scott.marlow.opensource at gmail.com Wed Nov 5 08:56:42 2008 From: scott.marlow.opensource at gmail.com (Scott Marlow) Date: Wed, 05 Nov 2008 11:56:42 -0500 Subject: 6423256: marking stacks should use a chunked data structure Message-ID: <4911D04A.8060900@gmail.com> Is anyone working on this bug yet? From the bug report http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6423256, it sounds like someone started the work already. I would like to help with the issue (either testing a proposed fix or submitting one). The bug report contains this text: " The marking stack used by MarkSweep currently uses a GrowableArray. That's overkill, since we only use the marking stack as a stack. In contrast, GrowableArray implements an array, so when it expands, it reallocs and copies the whole array to a new, larger, piece of contiguous memory. Since the marking stack is often large, this often requires a large contiguous chunk of memory, which can be difficult to acquire. Since GrowableArray grows by doubling, on average 25% of the array will be empty. When the marking stack is large, this can be a substantial waste of space. Instead, the stack could be implemented as a chained series of small regions. This could allow us to balance the storage for the chain pointers against the increment of growth, to use an appropriate amount of space in modest chunks. Posted Date : 2006-05-08 23:47:21.0 " Scott From Keith.McGuigan at Sun.COM Wed Nov 5 09:08:48 2008 From: Keith.McGuigan at Sun.COM (Keith McGuigan) Date: Wed, 05 Nov 2008 12:08:48 -0500 Subject: 6423256: marking stacks should use a chunked data structure In-Reply-To: <4911D04A.8060900@gmail.com> References: <4911D04A.8060900@gmail.com> Message-ID: <4911D320.5060503@sun.com> Hi Scott - I'm forwarding this to the hotspot-gc-dev mailing list. If anyone is working on it, they'll be on that list (maybe this one too, but just in case). -- - Keith Scott Marlow wrote: > Is anyone working on this bug yet? From the bug report > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6423256, it sounds > like someone started the work already. I would like to help with the > issue (either testing a proposed fix or submitting one). > > The bug report contains this text: > > " > The marking stack used by MarkSweep currently uses a GrowableArray. > That's overkill, since we only use the marking stack as a stack. In > contrast, GrowableArray implements an array, so when it expands, it > reallocs and copies the whole array to a new, larger, piece of > contiguous memory. Since the marking stack is often large, this often > requires a large contiguous chunk of memory, which can be difficult to > acquire. Since GrowableArray grows by doubling, on average 25% of the > array will be empty. When the marking stack is large, this can be a > substantial waste of space. > > Instead, the stack could be implemented as a chained series of small > regions. This could allow us to balance the storage for the chain > pointers against the increment of growth, to use an appropriate amount > of space in modest chunks. > Posted Date : 2006-05-08 23:47:21.0 > " > > > Scott > From Coleen.Phillimore at Sun.COM Wed Nov 5 14:04:46 2008 From: Coleen.Phillimore at Sun.COM (Coleen Phillimore - Sun Microsystems) Date: Wed, 05 Nov 2008 17:04:46 -0500 Subject: Please review (S) 6760773: UseCompressedOops is broken with UseParNewGC Message-ID: <4912187E.2090509@sun.com> The load was sign extending the compressed oop when running with very large Java heap, so that the compare with super class list for casting was failing. This causes ClassCastException with specjvm98. UseParNewGC was coincidental - just caues the oop to have sign bit set that we're looking for. Webrev: http://webrev.invokedynamic.info/coleenp/6760773 (internal) bug id: http://monaco.sfbay.sun.com/detail.jsf?cr=6760773 Thanks, Coleen From John.Coomes at sun.com Wed Nov 5 15:36:36 2008 From: John.Coomes at sun.com (John Coomes) Date: Wed, 5 Nov 2008 15:36:36 -0800 Subject: 6423256: marking stacks should use a chunked data structure In-Reply-To: <4911D04A.8060900@gmail.com> References: <4911D04A.8060900@gmail.com> Message-ID: <18706.11780.232560.191946@sun.com> Scott Marlow (scott.marlow.opensource at gmail.com) wrote: > Is anyone working on this bug yet? From the bug report > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6423256, it sounds > like someone started the work already. I would like to help with the > issue (either testing a proposed fix or submitting one). Hi Scott, Glad you want to help! One of our (former) colleagues implemented growable stacks just before he moved on to another group at Sun. I'm now the guardian of his changes. I haven't looked at it in detail, but I believe the code is complete and has had some testing. Certainly more would be in order. I'll post a webrev in a day or two. If you're willing you can review it and/or take the patch, build it and do some testing. -John > The bug report contains this text: > > " > The marking stack used by MarkSweep currently uses a GrowableArray. > That's overkill, since we only use the marking stack as a stack. In > contrast, GrowableArray implements an array, so when it expands, it > reallocs and copies the whole array to a new, larger, piece of > contiguous memory. Since the marking stack is often large, this often > requires a large contiguous chunk of memory, which can be difficult to > acquire. Since GrowableArray grows by doubling, on average 25% of the > array will be empty. When the marking stack is large, this can be a > substantial waste of space. > > Instead, the stack could be implemented as a chained series of small regions. This could allow us to balance the storage for the chain pointers against the increment of growth, to use an appropriate amount of space in modest chunks. > Posted Date : 2006-05-08 23:47:21.0 > " > > > Scott > From coleen.phillimore at sun.com Fri Nov 7 11:05:16 2008 From: coleen.phillimore at sun.com (coleen.phillimore at sun.com) Date: Fri, 07 Nov 2008 19:05:16 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6760773: UseCompressedOops is broken with UseParNewGC Message-ID: <20081107190521.389BFDF75@hg.openjdk.java.net> Changeset: 05db98ed59ba Author: coleenp Date: 2008-11-07 11:03 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/05db98ed59ba 6760773: UseCompressedOops is broken with UseParNewGC Summary: sparc code for gen_subtype_check was doing an ld for a compressed oop with the sign bit set so not comparing, leading to a ClassCastException. Reviewed-by: phh, never, acorn, kvn, xlu ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp From John.Coomes at sun.com Fri Nov 7 13:47:22 2008 From: John.Coomes at sun.com (John Coomes) Date: Fri, 7 Nov 2008 13:47:22 -0800 Subject: review request (XS) - 6718879 & 6769128 Message-ID: <18708.46954.411523.620823@sun.com> http://webrev.invokedynamic.info/jcoomes/6718879-build/ Details are in the bug reports. It may take a while for the updates to 6769128 propogate to bugs.sun.com, so 6718879: cannot build on solaris nevada Remove the assignment to ia_nice from os_solaris.cpp. 6769128: failure to run generateJvmOffsets is ignored Use a separate shell command to run generateJvmOffsets in dtrace.make. I also created a make macro to avoid repeating the shell command that conditionally updates the generated JvmOffset* files. Two files, 24 lines total. -John From john.coomes at sun.com Fri Nov 7 15:14:53 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 07 Nov 2008 23:14:53 +0000 Subject: hg: jdk7/hotspot-rt: Added tag jdk7-b39 for changeset ab523b49de1f Message-ID: <20081107231454.054B9D01E@hg.openjdk.java.net> Changeset: 44be42de6693 Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/44be42de6693 Added tag jdk7-b39 for changeset ab523b49de1f ! .hgtags From john.coomes at sun.com Fri Nov 7 15:16:26 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 07 Nov 2008 23:16:26 +0000 Subject: hg: jdk7/hotspot-rt/corba: Added tag jdk7-b39 for changeset 55078b6661e2 Message-ID: <20081107231628.7683CD023@hg.openjdk.java.net> Changeset: 184e21992f47 Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/184e21992f47 Added tag jdk7-b39 for changeset 55078b6661e2 ! .hgtags From john.coomes at sun.com Fri Nov 7 15:19:12 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 07 Nov 2008 23:19:12 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: Added tag jdk7-b39 for changeset 831b80be6cea Message-ID: <20081107231915.25B3DD028@hg.openjdk.java.net> Changeset: 54946f466e2c Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/54946f466e2c Added tag jdk7-b39 for changeset 831b80be6cea ! .hgtags From john.coomes at sun.com Fri Nov 7 15:20:49 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 07 Nov 2008 23:20:49 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: Added tag jdk7-b39 for changeset 077bc9b1b035 Message-ID: <20081107232051.90663D02D@hg.openjdk.java.net> Changeset: 70a6ac6dd737 Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/70a6ac6dd737 Added tag jdk7-b39 for changeset 077bc9b1b035 ! .hgtags From john.coomes at sun.com Fri Nov 7 15:23:11 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 07 Nov 2008 23:23:11 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 14 new changesets Message-ID: <20081107232613.90A3DD032@hg.openjdk.java.net> Changeset: 86799e45c230 Author: emcmanus Date: 2008-10-08 18:38 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/86799e45c230 6757225: MXBean: Incorrect type names for parametrized types, dealing with arrays Reviewed-by: sjiang ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/event/FetchingEventRelay.java ! src/share/classes/javax/management/monitor/Monitor.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java + test/javax/management/mxbean/TypeNameTest.java Changeset: 6a76dcaf15e3 Author: dfuchs Date: 2008-10-09 14:10 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/6a76dcaf15e3 6332953: JMX agent should bind to loopback address when starting the local connector server Reviewed-by: emcmanus ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java + src/share/classes/sun/management/jmxremote/LocalRMIServerSocketFactory.java ! src/share/lib/management/management.properties Changeset: f50f9b0d18a8 Author: dfuchs Date: 2008-10-10 10:58 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f50f9b0d18a8 6758165: ConnectorBootstrap.DefaultValues should have a default value for USE_LOCAL_ONLY Reviewed-by: alanb, emcmanus ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java Changeset: 214ebdcf7252 Author: sherman Date: 2008-10-13 14:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/214ebdcf7252 5025260: Register methods should throw ClosedChannelException instead of NPE Summary: update the spec and implementation to throw ClosedSelectorException Reviewed-by: alanb ! src/share/classes/java/nio/channels/SelectableChannel.java ! src/share/classes/java/nio/channels/spi/AbstractSelectableChannel.java ! src/share/classes/sun/nio/ch/AbstractPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/DevPollSelectorImpl.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java ! src/windows/classes/sun/nio/ch/WindowsSelectorImpl.java + test/java/nio/channels/Selector/CloseThenRegister.java Changeset: 5eab86fc2ea8 Author: tbell Date: 2008-10-17 16:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/5eab86fc2ea8 Merge Changeset: 486b917ed417 Author: mullan Date: 2008-10-07 13:41 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/486b917ed417 6752764: PIT B37: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest failed Summary: fix regression introduced by 6465942 Reviewed-by: vinnie ! src/share/classes/sun/security/provider/certpath/BasicChecker.java Changeset: 3c234822b837 Author: mullan Date: 2008-10-07 13:48 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3c234822b837 Merge - src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java - src/share/classes/java/nio/channels/package.html - src/share/classes/org/jcp/xml/dsig/internal/package.html - src/share/classes/sun/nio/ch/OptionAdaptor.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h - src/solaris/javavm/include/typedefs_md.h - src/windows/javavm/include/typedefs_md.h Changeset: 8b2d7e577d4a Author: mullan Date: 2008-10-07 14:44 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8b2d7e577d4a Merge Changeset: 3f051f3ba5bb Author: weijun Date: 2008-10-17 13:02 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/3f051f3ba5bb 6706974: Add krb5 test infrastructure Reviewed-by: valeriep + test/sun/security/krb5/auto/Action.java + test/sun/security/krb5/auto/BasicKrb5Test.java + test/sun/security/krb5/auto/CleanState.java + test/sun/security/krb5/auto/Context.java + test/sun/security/krb5/auto/CrossRealm.java + test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/KerberosHashEqualsTest.java + test/sun/security/krb5/auto/OneKDC.java + test/sun/security/krb5/auto/basic.sh Changeset: 064e6a087f77 Author: wetmore Date: 2008-10-17 00:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/064e6a087f77 Merge Changeset: 0bf6c9c6fdc5 Author: weijun Date: 2008-10-20 10:32 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/0bf6c9c6fdc5 6761072: new krb5 tests fail on multiple platforms Reviewed-by: xuelei ! test/sun/security/krb5/auto/BasicKrb5Test.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OneKDC.java Changeset: 7df3f9183f67 Author: wetmore Date: 2008-10-20 01:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/7df3f9183f67 Merge Changeset: 4e51997582ef Author: tbell Date: 2008-10-23 21:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4e51997582ef Merge Changeset: 2914c04c8644 Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2914c04c8644 Added tag jdk7-b39 for changeset 4e51997582ef ! .hgtags From john.coomes at sun.com Fri Nov 7 15:31:22 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 07 Nov 2008 23:31:22 +0000 Subject: hg: jdk7/hotspot-rt/langtools: 22 new changesets Message-ID: <20081107233158.66579D037@hg.openjdk.java.net> Changeset: a54ef8459576 Author: jjg Date: 2008-10-07 15:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/a54ef8459576 6749967: regression tests for apt should be same-vm friendly Reviewed-by: darcy ! test/tools/apt/mirror/declaration/AnnoMirror.java ! test/tools/apt/mirror/declaration/AnnoTypeDecl.java ! test/tools/apt/mirror/declaration/AnnoTypeElemDecl.java ! test/tools/apt/mirror/declaration/AnnoVal.java ! test/tools/apt/mirror/declaration/ClassDecl.java ! test/tools/apt/mirror/declaration/ConstExpr.java ! test/tools/apt/mirror/declaration/ConstructorDecl.java ! test/tools/apt/mirror/declaration/EnumDecl.java ! test/tools/apt/mirror/declaration/FieldDecl.java ! test/tools/apt/mirror/declaration/GetAnno.java ! test/tools/apt/mirror/declaration/InterfaceDecl.java ! test/tools/apt/mirror/declaration/MethodDecl.java ! test/tools/apt/mirror/declaration/PackageDecl.java ! test/tools/apt/mirror/declaration/ParameterDecl.java ! test/tools/apt/mirror/type/AnnoTyp.java ! test/tools/apt/mirror/type/ArrayTyp.java ! test/tools/apt/mirror/type/ClassTyp.java ! test/tools/apt/mirror/type/EnumTyp.java ! test/tools/apt/mirror/type/InterfaceTyp.java ! test/tools/apt/mirror/type/PrimitiveTyp.java ! test/tools/apt/mirror/type/TypeVar.java ! test/tools/apt/mirror/type/WildcardTyp.java ! test/tools/apt/mirror/util/Overrides.java ! test/tools/apt/mirror/util/TypeCreation.java Changeset: c0372d1097c0 Author: mcimadamore Date: 2008-10-09 15:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/c0372d1097c0 6751514: Unary post-increment with type variables crash javac during lowering Summary: Lower.abstractRval should take into account parenthesized expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/generics/T6751514.java Changeset: 8c098cf64ab5 Author: mcimadamore Date: 2008-10-09 16:02 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8c098cf64ab5 6738538: javac crashes when using a type parameter as a covariant method return type Summary: Capture conversion should be applied when acccessing a member of an intersection type Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/OverrideChecks/6738538/T6738538a.java + test/tools/javac/OverrideChecks/6738538/T6738538b.java Changeset: ac6ce899d007 Author: mcimadamore Date: 2008-10-09 16:04 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/ac6ce899d007 6724345: incorrect method resolution for enum classes entered as source files Summary: Enum's abstract methods shouldn't be skipped during method resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/enum/T6724345.java Changeset: 8eafba4f61be Author: mcimadamore Date: 2008-10-09 16:07 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8eafba4f61be 6406133: JCDiagnostic.getMessage ignores locale argument Summary: Compiler API should take into account locale settings Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/javac/api/Formattable.java ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java + src/share/classes/com/sun/tools/javac/api/Messages.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/parser/Token.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java + src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! test/tools/javac/6457284/T6457284.java + test/tools/javac/api/6406133/Erroneous.java + test/tools/javac/api/6406133/T6406133.java Changeset: e4eaddca54b7 Author: mcimadamore Date: 2008-10-09 16:19 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/e4eaddca54b7 6731573: diagnostic output should optionally include source line Summary: Added an -XD option to optionally prints out source lines in error messages Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java + test/tools/javac/api/6731573/Erroneous.java + test/tools/javac/api/6731573/T6731573.java Changeset: d766e40e49d6 Author: mcimadamore Date: 2008-10-09 16:21 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/d766e40e49d6 6586091: javac crashes with StackOverflowError Summary: Types.adapt should avoid infinite loops by exploiting a local cache Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6586091/T6586091.java Changeset: e03459165ec4 Author: mcimadamore Date: 2008-10-14 17:05 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/e03459165ec4 6759143: com.sun.tools.javac.util.Messages is obsolete and should be removed Summary: push for 6406133 should have removed com.sun.tools.javac.util.Messages Reviewed-by: jjg - src/share/classes/com/sun/tools/javac/util/Messages.java Changeset: 22c4c1143a3a Author: jjg Date: 2008-10-15 08:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/22c4c1143a3a 6748541: javadoc should be reusable Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/lib/JavadocTester.java ! test/tools/javadoc/BooleanConst.java ! test/tools/javadoc/BreakIteratorWarning.java ! test/tools/javadoc/FlagsTooEarly.java ! test/tools/javadoc/InlineTagsWithBraces.java ! test/tools/javadoc/LangVers.java ! test/tools/javadoc/MethodLinks.java ! test/tools/javadoc/NoStar.java ! test/tools/javadoc/T4994049/T4994049.java ! test/tools/javadoc/XWerror.java ! test/tools/javadoc/completionFailure/CompletionFailure.java ! test/tools/javadoc/dupOk/DupOk.java ! test/tools/javadoc/imports/MissingImport.java ! test/tools/javadoc/lib/Tester.java ! test/tools/javadoc/nestedClass/NestedClass.java ! test/tools/javadoc/sourceOnly/p/SourceOnly.java ! test/tools/javadoc/sourceOption/SourceOption.java ! test/tools/javadoc/subpackageIgnore/SubpackageIgnore.java Changeset: 83ffdd1a6294 Author: mcimadamore Date: 2008-10-15 17:23 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/83ffdd1a6294 6759682: APT: compiler message file broken after refactoring of com.sun.tools.javac.util.Message Summary: JavacMessages should refresh its own bundle cache when a new resource bundle is added by APT Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java Changeset: e1332c04f6b6 Author: jjg Date: 2008-10-15 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/e1332c04f6b6 6759795: test/tools/apt/Basic/print.sh may fail depending on jtreg options Reviewed-by: darcy ! test/tools/apt/Basics/print.sh Changeset: 4feda9f0dbe7 Author: jjg Date: 2008-10-15 13:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/4feda9f0dbe7 6759796: test/tools/javac/6348193/T6348193.java fails if there are empty entries on the bootclasspath Reviewed-by: darcy ! test/tools/javac/processing/6348193/T6348193.java Changeset: 173162d6eb1d Author: jjg Date: 2008-10-16 07:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/173162d6eb1d 6759775: RegularFileObject.inferBinaryName gives bad result on empty path Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java Changeset: 2c1ef6ec9413 Author: jjg Date: 2008-10-16 07:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/2c1ef6ec9413 6759810: bad regression test causes source file to be deleted Reviewed-by: mcimadamore ! test/tools/javac/links/T.java ! test/tools/javac/links/links.sh Changeset: 6fcc8de719f5 Author: mcimadamore Date: 2008-10-16 18:07 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/6fcc8de719f5 6760226: test/tools/javap/T6622260.java fails with specific locale settings Summary: Changed the regression test in order to make it more robust w.r.t. to locale settings Reviewed-by: jjg ! test/tools/javap/T6622260.java Changeset: 402183e8d6e1 Author: jjg Date: 2008-10-16 16:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/402183e8d6e1 6760500: test com/sun/javadoc/testSupplementary/TestSupplementary.java is not same-VM safe Reviewed-by: darcy ! test/com/sun/javadoc/testSupplementary/TestSupplementary.java Changeset: eca4bf37b66e Author: jjg Date: 2008-10-17 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/eca4bf37b66e 6760805: empty element on bootclasspath breaks test/tools/apt/Compile/compile.sh Reviewed-by: darcy ! test/tools/apt/Compile/compile.sh Changeset: 2eec479619d8 Author: jjg Date: 2008-10-17 16:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/2eec479619d8 6760930: empty element on bootclasspath breaks test/tools/apt/Discovery/discovery.sh Reviewed-by: darcy ! test/tools/apt/Discovery/discovery.sh Changeset: acc41893695b Author: tbell Date: 2008-10-17 16:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/acc41893695b Merge - src/share/classes/com/sun/tools/javac/util/Messages.java Changeset: 8ae974495e73 Author: jjg Date: 2008-10-20 13:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8ae974495e73 6759996: ignore empty entries on paths Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/Paths.java + test/tools/javac/T6759996.java Changeset: 3fb51e47622b Author: tbell Date: 2008-10-23 21:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/3fb51e47622b Merge Changeset: 968ca53217a1 Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/968ca53217a1 Added tag jdk7-b39 for changeset 3fb51e47622b ! .hgtags From scott.marlow.opensource at gmail.com Fri Nov 7 20:34:52 2008 From: scott.marlow.opensource at gmail.com (Scott Marlow) Date: Fri, 07 Nov 2008 23:34:52 -0500 Subject: 6423256: marking stacks should use a chunked data structure In-Reply-To: <18706.11780.232560.191946@sun.com> References: <4911D04A.8060900@gmail.com> <18706.11780.232560.191946@sun.com> Message-ID: <491516EC.6040905@gmail.com> John Coomes wrote: > Scott Marlow (scott.marlow.opensource at gmail.com) wrote: > >> Is anyone working on this bug yet? From the bug report >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6423256, it sounds >> like someone started the work already. I would like to help with the >> issue (either testing a proposed fix or submitting one). >> > > Hi Scott, > > Glad you want to help! One of our (former) colleagues implemented > growable stacks just before he moved on to another group at Sun. I'm > now the guardian of his changes. I haven't looked at it in detail, > but I believe the code is complete and has had some testing. > Certainly more would be in order. > > I'll post a webrev in a day or two. If you're willing you can review > it and/or take the patch, build it and do some testing. > > -John > John, I just got the build to work successfully on my Windows machine (with some help from build-dev at openjdk.java.net). I should be able to review the change and apply the patch (for testing) when your ready. Scott -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20081107/b87a5d0a/attachment.html From twisti at complang.tuwien.ac.at Sun Nov 9 09:39:29 2008 From: twisti at complang.tuwien.ac.at (Christian Thalinger) Date: Sun, 09 Nov 2008 18:39:29 +0100 Subject: review request (XS) - 6718879 & 6769128 In-Reply-To: <18708.46954.411523.620823@sun.com> References: <18708.46954.411523.620823@sun.com> Message-ID: <1226252369.1268.0.camel@localhost.localdomain> On Fri, 2008-11-07 at 13:47 -0800, John Coomes wrote: > http://webrev.invokedynamic.info/jcoomes/6718879-build/ > > Details are in the bug reports. It may take a while for the updates > to 6769128 propogate to bugs.sun.com, so > > 6718879: cannot build on solaris nevada > > Remove the assignment to ia_nice from os_solaris.cpp. Thanks for this one. - Christian From John.Coomes at sun.com Wed Nov 12 16:26:15 2008 From: John.Coomes at sun.com (John Coomes) Date: Wed, 12 Nov 2008 16:26:15 -0800 Subject: 6423256: marking stacks should use a chunked data structure In-Reply-To: <18706.11780.232560.191946@sun.com> References: <4911D04A.8060900@gmail.com> <18706.11780.232560.191946@sun.com> Message-ID: <18715.29735.540039.433458@sun.com> John Coomes (John.Coomes at sun.com) wrote: > Scott Marlow (scott.marlow.opensource at gmail.com) wrote: > > Is anyone working on this bug yet? From the bug report > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6423256, it sounds > > like someone started the work already. I would like to help with the > > issue (either testing a proposed fix or submitting one). > > Hi Scott, > > Glad you want to help! One of our (former) colleagues implemented > growable stacks just before he moved on to another group at Sun. I'm > now the guardian of his changes. I haven't looked at it in detail, > but I believe the code is complete and has had some testing. > Certainly more would be in order. > > I'll post a webrev in a day or two. If you're willing you can review > it and/or take the patch, build it and do some testing. I guess really I meant a week or two :-(. Sorry, I've been out sick. Anyway, I put a webrev here: http://webrev.invokedynamic.info/jcoomes/6423256-stack/ I'd consider these preliminary since I haven't tested the changes after syncing them up, other than to do a few builds (it compiles cleanly on solaris). -John > > The bug report contains this text: > > > > " > > The marking stack used by MarkSweep currently uses a GrowableArray. > > That's overkill, since we only use the marking stack as a stack. In > > contrast, GrowableArray implements an array, so when it expands, it > > reallocs and copies the whole array to a new, larger, piece of > > contiguous memory. Since the marking stack is often large, this often > > requires a large contiguous chunk of memory, which can be difficult to > > acquire. Since GrowableArray grows by doubling, on average 25% of the > > array will be empty. When the marking stack is large, this can be a > > substantial waste of space. > > > > Instead, the stack could be implemented as a chained series of small regions. This could allow us to balance the storage for the chain pointers against the increment of growth, to use an appropriate amount of space in modest chunks. > > Posted Date : 2006-05-08 23:47:21.0 > > " > > > > > > Scott > > From keith.mcguigan at sun.com Fri Nov 14 11:37:57 2008 From: keith.mcguigan at sun.com (keith.mcguigan at sun.com) Date: Fri, 14 Nov 2008 19:37:57 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 8 new changesets Message-ID: <20081114193815.D5ECED490@hg.openjdk.java.net> Changeset: 4d9884b01ba6 Author: never Date: 2008-10-28 09:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/4d9884b01ba6 6754519: don't emit flag fixup for NaN when condition being tested doesn't need it Reviewed-by: kvn, rasbold ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/filebuff.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/reg_split.cpp Changeset: b6cfd754403d Author: never Date: 2008-10-28 18:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b6cfd754403d 6649622: HotSpot Biased locking needs tuning on latest CPUs Reviewed-by: rasbold, kvn, kamg ! src/share/vm/runtime/arguments.cpp Changeset: f4fe12e429a4 Author: never Date: 2008-10-30 17:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/f4fe12e429a4 6764622: IdealGraphVisualizer fixes Reviewed-by: rasbold, jrose ! src/share/tools/IdealGraphVisualizer/Bytecodes/src/com/sun/hotspot/igv/bytecodes/BytecodeViewTopComponent.java ! src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowScene.java ! src/share/tools/IdealGraphVisualizer/ControlFlow/src/com/sun/hotspot/igv/controlflow/ControlFlowTopComponent.java ! src/share/tools/IdealGraphVisualizer/Coordinator/src/com/sun/hotspot/igv/coordinator/FolderNode.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/GraphDocument.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Group.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputGraph.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputMethod.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/InputNode.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Properties.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/Property.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Printer.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLParser.java ! src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/XMLWriter.java ! src/share/tools/IdealGraphVisualizer/Difference/src/com/sun/hotspot/igv/difference/Difference.java ! src/share/tools/IdealGraphVisualizer/Filter/manifest.mf ! src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/CustomFilter.java ! src/share/tools/IdealGraphVisualizer/Filter/src/com/sun/hotspot/igv/filter/SplitFilter.java ! src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Diagram.java ! src/share/tools/IdealGraphVisualizer/Graph/src/com/sun/hotspot/igv/graph/Figure.java ! src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/Graph.java ! src/share/tools/IdealGraphVisualizer/HierarchicalLayout/src/com/sun/hotspot/igv/hierarchicallayout/HierarchicalClusterLayoutManager.java ! src/share/tools/IdealGraphVisualizer/Layout/src/com/sun/hotspot/igv/layout/LayoutGraph.java ! src/share/tools/IdealGraphVisualizer/README ! src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/PropertiesSheet.java ! src/share/tools/IdealGraphVisualizer/Util/src/com/sun/hotspot/igv/util/RangeSliderModel.java ! src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/DiagramScene.java ! src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/DiagramViewModel.java ! src/share/tools/IdealGraphVisualizer/View/src/com/sun/hotspot/igv/view/FindPanel.java ! src/share/tools/IdealGraphVisualizer/nbproject/platform.properties ! src/share/tools/IdealGraphVisualizer/nbproject/project.properties ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/frame.cpp Changeset: 72c5366e5d86 Author: rasbold Date: 2008-11-06 14:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/72c5366e5d86 6743900: frequency based block layout Summary: post-register allocation pass that drives block layout by edge frequencies Reviewed-by: never, kvn ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/phase.cpp ! src/share/vm/opto/phase.hpp Changeset: 0bf25c4807f9 Author: never Date: 2008-11-06 20:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/0bf25c4807f9 6761594: framesize rounding code rounds using wrong units leading to slightly oversized frames Reviewed-by: rasbold, kvn ! src/share/vm/opto/chaitin.cpp Changeset: a1980da045cc Author: kvn Date: 2008-11-07 09:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a1980da045cc 6462850: generate biased locking code in C2 ideal graph Summary: Inline biased locking code in C2 ideal graph during macro nodes expansion Reviewed-by: never ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/linux_x86/vm/linux_x86_32.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_32.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/utilities/vmError.cpp Changeset: 577f3a2e0662 Author: never Date: 2008-11-07 13:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/577f3a2e0662 Merge Changeset: 909cfd030fab Author: kamg Date: 2008-11-12 11:23 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/909cfd030fab Merge From coleen.phillimore at sun.com Fri Nov 21 11:05:07 2008 From: coleen.phillimore at sun.com (coleen.phillimore at sun.com) Date: Fri, 21 Nov 2008 19:05:07 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6676175: BigApps crash JVM Client VM (build 10.0-b22, mixed mode, sharing) with SIGSEGV (0xb) Message-ID: <20081121190510.47187D8C0@hg.openjdk.java.net> Changeset: 2b42b31e7928 Author: coleenp Date: 2008-11-21 08:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/2b42b31e7928 6676175: BigApps crash JVM Client VM (build 10.0-b22, mixed mode, sharing) with SIGSEGV (0xb) Summary: Add test for biased locking epoch before walking own thread stack in case of rare race Reviewed-by: phh, never ! src/share/vm/runtime/biasedLocking.cpp From keith.mcguigan at sun.com Fri Nov 21 14:57:25 2008 From: keith.mcguigan at sun.com (keith.mcguigan at sun.com) Date: Fri, 21 Nov 2008 22:57:25 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 21 new changesets Message-ID: <20081121225805.D1E4AD8E4@hg.openjdk.java.net> Changeset: 42ca4002efc2 Author: xdono Date: 2008-11-06 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/42ca4002efc2 Added tag jdk7-b39 for changeset 49ca90d77f34 ! .hgtags Changeset: 7704802ec1ce Author: trims Date: 2008-11-14 19:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/7704802ec1ce Merge Changeset: 81a0cbe3b284 Author: trims Date: 2008-11-14 19:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/81a0cbe3b284 6771977: Bump HS14 build number to 07 Summary: Update the Hotspot build number to 07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 3c07cda72b7d Author: tbell Date: 2008-11-11 22:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/3c07cda72b7d 6764892: VS2008 changes required to compile hotspot sources Summary: Minor changes required to build using the Visual Studio 2008 compiler Reviewed-by: kvn, ohair ! make/windows/makefiles/adlc.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/sa.make ! src/cpu/x86/vm/register_definitions_x86.cpp Changeset: 334969144810 Author: never Date: 2008-11-11 23:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/334969144810 6758445: loop heads that are exception entry points can crash during count_edges/mark_loops Reviewed-by: kvn, jrose ! src/share/vm/c1/c1_IR.cpp Changeset: 364141474b40 Author: never Date: 2008-11-12 05:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/364141474b40 Merge Changeset: 4d20a3aaf1ab Author: kvn Date: 2008-11-12 11:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/4d20a3aaf1ab 6769748: Fix solaris makefiles for the case when "CC -V" produces several lines Summary: Fix solaris makefiles for 5.10 compilers Reviewed-by: jcoomes ! make/solaris/makefiles/debug.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/i486.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/product.make ! make/solaris/makefiles/sparc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/sparcv9.make ! make/solaris/makefiles/vm.make Changeset: a45484ea312d Author: jrose Date: 2008-11-12 22:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/a45484ea312d 6653858: dynamic languages need to be able to load anonymous classes Summary: low-level privileged sun.misc.Unsafe.defineAnonymousClass Reviewed-by: kvn ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/includeDB_gc_parallel ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/utilities/constantTag.hpp Changeset: 275a3b7ff0d6 Author: jrose Date: 2008-11-12 23:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/275a3b7ff0d6 6770949: minor tweaks before 6655638 Summary: minor cleanups & tuning of array.hpp, debug.cpp, growableArray.hpp, hashtable.cpp Reviewed-by: kvn ! src/share/vm/utilities/array.hpp ! src/share/vm/utilities/debug.cpp ! src/share/vm/utilities/growableArray.hpp ! src/share/vm/utilities/hashtable.cpp Changeset: c1345e85f901 Author: kvn Date: 2008-11-13 14:50 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/c1345e85f901 6767659: Conversion from i486 to x86 missed some entries in makefiles Summary: Fixed missed entries. Reviewed-by: never ! make/linux/makefiles/top.make ! make/solaris/makefiles/amd64.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/fastdebug.make ! make/solaris/makefiles/i486.make ! make/solaris/makefiles/sparc.make ! make/solaris/makefiles/top.make ! src/share/vm/adlc/archDesc.cpp Changeset: de78b80cedec Author: kvn Date: 2008-11-18 12:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/de78b80cedec 6772413: code cleanup Summary: Removed lines in adm64.make with interpret.o and moved few constant strings from header files. Reviewed-by: never ! make/solaris/makefiles/amd64.make ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/perfMemory.hpp Changeset: b1d6a3e95810 Author: kvn Date: 2008-11-18 12:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b1d6a3e95810 6766316: assert(!nocreate,"Cannot build a phi for a block already parsed.") Summary: Don't use the invariant local information if there are irreducible loops. Reviewed-by: never ! src/share/vm/opto/parse.hpp Changeset: 87559db65269 Author: kvn Date: 2008-11-18 14:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/87559db65269 6773078: UseCompressedOops: assert(kid == 0L || s->_leaf->in(0) == 0L,"internal operands have no control") Summary: Don't set the control edge of a klass load node. Reviewed-by: never ! src/share/vm/opto/macro.cpp Changeset: 491a904952f2 Author: kvn Date: 2008-11-19 09:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/491a904952f2 Merge Changeset: 122d10c82f3f Author: jcoomes Date: 2008-10-29 06:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/122d10c82f3f 6765804: GC "dead ratios" should be unsigned Reviewed-by: ysr, tonyp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/space.hpp ! src/share/vm/memory/tenuredGeneration.hpp ! src/share/vm/runtime/globals.hpp Changeset: 03f4fdd1b6af Author: jcoomes Date: 2008-11-11 22:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/03f4fdd1b6af 6718879: cannot build on solaris nevada Reviewed-by: xlu ! src/os/solaris/vm/os_solaris.cpp Changeset: 96c6da8f095c Author: jcoomes Date: 2008-11-07 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/96c6da8f095c 6769128: failure to run generateJvmOffsets is ignored Reviewed-by: xlu ! make/solaris/makefiles/dtrace.make Changeset: da9cb4e97a5f Author: iveresov Date: 2008-11-14 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/da9cb4e97a5f 6770608: G1: Mutator thread can flush barrier and satb queues during safepoint 6660573: G1: BigApps Failure : guarantee(satb_mq_set.completed_buffers_num() == 0,"invariant") Summary: When exiting a mutator thread is removed from the thread list before it has a chance to flush its SATB and barrier queues. If GC happens at this moment the objects that are refererred from these queues can be moved, which will case a crash. The fix is simply to flush the buffers before removing a thread from the list. Reviewed-by: jcoomes, tonyp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/ptrQueue.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 8fa025608ec6 Author: jmasa Date: 2008-11-18 14:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/8fa025608ec6 6771742: Remove duplicate files from G1 merge Summary: Remove duplicate files and add includeDB_gc_g1 file in windows Makefile Reviewed-by: jcoomes, ysr ! make/windows/projectfiles/common/Makefile - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.hpp Changeset: b5e603f2e024 Author: iveresov Date: 2008-11-19 14:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b5e603f2e024 Merge ! make/solaris/makefiles/dtrace.make - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.hpp ! src/share/vm/runtime/globals.hpp Changeset: ba7f9d894282 Author: kamg Date: 2008-11-21 15:10 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/ba7f9d894282 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/concurrentGCThread.hpp From xiaobin.lu at sun.com Sat Nov 22 03:13:12 2008 From: xiaobin.lu at sun.com (xiaobin.lu at sun.com) Date: Sat, 22 Nov 2008 11:13:12 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6554406: Change switch UseVMInterruptibleIO default to false (sol) Message-ID: <20081122111314.B4980D925@hg.openjdk.java.net> Changeset: 171e581e8161 Author: xlu Date: 2008-11-22 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/171e581e8161 6554406: Change switch UseVMInterruptibleIO default to false (sol) Summary: The default value of UseVMInterruptibleIO is changed to false for JDK 7, but the default isn't changed for JDK 6 and earlier. Reviewed-by: never, acorn, dholmes, kamg, alanb ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp From Coleen.Phillimore at Sun.COM Mon Nov 24 10:33:34 2008 From: Coleen.Phillimore at Sun.COM (Coleen Phillimore - Sun Microsystems) Date: Mon, 24 Nov 2008 13:33:34 -0500 Subject: Please review (XS) 6474243: suspicious jvmti code that uses oop unsafely across GC point Message-ID: <492AF37E.8070009@sun.com> Summary: oop stored in unsafely in Lscratch noticed by visual inspection will not be updated by GC. http://webrev.invokedynamic.info/coleenp/6474243 Thanks, Coleen From coleen.phillimore at sun.com Mon Nov 24 14:35:25 2008 From: coleen.phillimore at sun.com (coleen.phillimore at sun.com) Date: Mon, 24 Nov 2008 22:35:25 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 6474243: suspicious jvmti code that uses oop unsafely across GC point Message-ID: <20081124223528.786FFDB18@hg.openjdk.java.net> Changeset: b22701a8b88f Author: coleenp Date: 2008-11-24 14:45 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/b22701a8b88f 6474243: suspicious jvmti code that uses oop unsafely across GC point Summary: oop stored in unsafely in Lscratch noticed by visual inspection will not be updated by GC. Reviewed-by: kamg, never, kvn ! src/cpu/sparc/vm/templateTable_sparc.cpp From john.coomes at sun.com Mon Nov 24 16:10:38 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Tue, 25 Nov 2008 00:10:38 +0000 Subject: hg: jdk7/hotspot-rt: Added tag jdk7-b40 for changeset 44be42de6693 Message-ID: <20081125001038.B42E7DB69@hg.openjdk.java.net> Changeset: 8c34e4abcb43 Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/rev/8c34e4abcb43 Added tag jdk7-b40 for changeset 44be42de6693 ! .hgtags From john.coomes at sun.com Mon Nov 24 16:13:56 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Tue, 25 Nov 2008 00:13:56 +0000 Subject: hg: jdk7/hotspot-rt/corba: Added tag jdk7-b40 for changeset 184e21992f47 Message-ID: <20081125001357.158F0DB6E@hg.openjdk.java.net> Changeset: c90eeda9594e Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/corba/rev/c90eeda9594e Added tag jdk7-b40 for changeset 184e21992f47 ! .hgtags From john.coomes at sun.com Mon Nov 24 16:19:24 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Tue, 25 Nov 2008 00:19:24 +0000 Subject: hg: jdk7/hotspot-rt/jaxp: Added tag jdk7-b40 for changeset 54946f466e2c Message-ID: <20081125001925.E66A7DB73@hg.openjdk.java.net> Changeset: 0758bd3e2852 Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxp/rev/0758bd3e2852 Added tag jdk7-b40 for changeset 54946f466e2c ! .hgtags From john.coomes at sun.com Mon Nov 24 16:23:01 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Tue, 25 Nov 2008 00:23:01 +0000 Subject: hg: jdk7/hotspot-rt/jaxws: Added tag jdk7-b40 for changeset 70a6ac6dd737 Message-ID: <20081125002303.2A2A3DB79@hg.openjdk.java.net> Changeset: a8379d24aa03 Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jaxws/rev/a8379d24aa03 Added tag jdk7-b40 for changeset 70a6ac6dd737 ! .hgtags From john.coomes at sun.com Mon Nov 24 16:26:34 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Tue, 25 Nov 2008 00:26:34 +0000 Subject: hg: jdk7/hotspot-rt/jdk: 12 new changesets Message-ID: <20081125002902.E6A36DB7E@hg.openjdk.java.net> Changeset: 64da1f751c0f Author: martin Date: 2008-10-24 20:34 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/64da1f751c0f 6761678: (ann) SecurityException in AnnotationInvocationHandler.getMemberMethods Summary: Move call to getDeclaredMethods inside doPrivileged Reviewed-by: darcy, mullan Contributed-by: jjb at google.com ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java + test/java/lang/annotation/ParameterAnnotations.java Changeset: 1a324821b463 Author: tbell Date: 2008-10-24 20:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/1a324821b463 Merge Changeset: 76ecb928e83a Author: emcmanus Date: 2008-10-27 14:02 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/76ecb928e83a 6763639: Remove "rawtypes" warnings from JMX code Reviewed-by: dfuchs ! make/netbeans/jmx/build.xml ! src/share/classes/com/sun/jmx/event/LeaseManager.java ! src/share/classes/com/sun/jmx/event/LeaseRenewer.java ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java ! src/share/classes/com/sun/jmx/mbeanserver/ConvertingMethod.java ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/com/sun/jmx/mbeanserver/JmxMBeanServer.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInstantiator.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/com/sun/jmx/mbeanserver/ObjectInputStreamWithLoader.java ! src/share/classes/com/sun/jmx/mbeanserver/SecureClassLoaderRepository.java ! src/share/classes/com/sun/jmx/mbeanserver/Util.java ! src/share/classes/com/sun/jmx/mbeanserver/WeakIdentityHashMap.java ! src/share/classes/com/sun/jmx/remote/internal/ArrayNotificationBuffer.java ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/Unmarshal.java ! src/share/classes/com/sun/jmx/remote/security/FileLoginModule.java ! src/share/classes/com/sun/jmx/remote/security/JMXPluggableAuthenticator.java ! src/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/share/classes/com/sun/jmx/remote/util/ClassLoaderWithRepository.java ! src/share/classes/com/sun/jmx/remote/util/ClassLogger.java ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java ! src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java ! src/share/classes/com/sun/jmx/remote/util/OrderClassLoaders.java ! src/share/classes/javax/management/AttributeList.java ! src/share/classes/javax/management/DefaultLoaderRepository.java ! src/share/classes/javax/management/JMRuntimeException.java ! src/share/classes/javax/management/JMX.java ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/management/MBeanConstructorInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanOperationInfo.java ! src/share/classes/javax/management/MBeanServerFactory.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java ! src/share/classes/javax/management/StandardMBean.java ! src/share/classes/javax/management/event/EventClientDelegate.java ! src/share/classes/javax/management/event/EventSubscriber.java ! src/share/classes/javax/management/loading/DefaultLoaderRepository.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/loading/MLetObjectInputStream.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/openmbean/ArrayType.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/management/openmbean/CompositeType.java ! src/share/classes/javax/management/openmbean/OpenMBeanAttributeInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenMBeanParameterInfoSupport.java ! src/share/classes/javax/management/openmbean/OpenType.java ! src/share/classes/javax/management/openmbean/SimpleType.java ! src/share/classes/javax/management/openmbean/TabularDataSupport.java ! src/share/classes/javax/management/openmbean/TabularType.java ! src/share/classes/javax/management/relation/MBeanServerNotificationFilter.java ! src/share/classes/javax/management/relation/RelationService.java ! src/share/classes/javax/management/relation/RelationSupport.java ! src/share/classes/javax/management/relation/Role.java ! src/share/classes/javax/management/relation/RoleList.java ! src/share/classes/javax/management/relation/RoleResult.java ! src/share/classes/javax/management/relation/RoleUnresolved.java ! src/share/classes/javax/management/relation/RoleUnresolvedList.java ! src/share/classes/javax/management/remote/JMXConnectorFactory.java ! src/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java ! src/share/classes/javax/management/remote/rmi/RMIConnection.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java ! src/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! src/share/classes/javax/management/timer/Timer.java Changeset: 98ac3d398ed6 Author: chegar Date: 2008-10-28 16:14 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/98ac3d398ed6 6756771: com.sun.net.httpserver.HttpServer should handle POSTs larger than 2Gig Summary: update implementation to use long instead of int Reviewed-by: michaelm ! src/share/classes/sun/net/httpserver/ExchangeImpl.java ! src/share/classes/sun/net/httpserver/FixedLengthInputStream.java ! src/share/classes/sun/net/httpserver/Request.java ! src/share/classes/sun/net/httpserver/ServerImpl.java + test/com/sun/net/httpserver/bugs/FixedLengthInputStream.java Changeset: 58e52eb46bd3 Author: emcmanus Date: 2008-10-28 18:21 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/58e52eb46bd3 6763051: MXBean: Incorrect type names for parametrized dealing with arrays (openType) 6713777: developer diagnosability of errors in uncompliant mxbean interfaces Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/com/sun/jmx/mbeanserver/MXBeanIntrospector.java ! src/share/classes/javax/management/MBeanServerInvocationHandler.java + test/javax/management/mxbean/ExceptionDiagnosisTest.java ! test/javax/management/mxbean/TypeNameTest.java Changeset: 8dcde0b16199 Author: emcmanus Date: 2008-10-30 17:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8dcde0b16199 6252609: Two different default descriptor forms defined for ModelMBeanInfoSupport 6253137: Documentation for NotificationListener's handback parameter is confusing 6368691: javadoc for JMX Descriptors has bugs and is very hard to navigate. 6602699: support for async notification of mbeaninfo update 6759612: [javadoc] EventClient.NOTIFS_LOST has a garbled href to addEventClientListener 6759619: Clarify what EventClient.getEventClientNotificationInfo does 6759622: Clarify what EventClient.getListeners list does Summary: Documentation fixes, plus simple bugfix for 6759619. Reviewed-by: dfuchs ! src/share/classes/javax/management/Descriptor.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/NotificationListener.java ! src/share/classes/javax/management/event/EventClient.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanConstructorInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java ! src/share/classes/javax/management/modelmbean/ModelMBeanOperationInfo.java ! test/javax/management/eventService/CustomForwarderTest.java ! test/javax/management/mxbean/TypeNameTest.java Changeset: cdfb6f963a60 Author: emcmanus Date: 2008-10-30 18:19 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/cdfb6f963a60 6450848: make it easier to get the ObjectName of a JMX Proxy Summary: Rework proxy javadoc to explain how to do this. Reviewed-by: sjiang ! src/share/classes/javax/management/JMX.java Changeset: 4ff842aee1fd Author: mullan Date: 2008-10-30 17:24 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/4ff842aee1fd 6764553: com.sun.org.apache.xml.internal.security.utils.IdResolver is not thread safe Reviewed-by: valeriep ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java Changeset: f246770bcc78 Author: mullan Date: 2008-10-30 17:28 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/f246770bcc78 Merge Changeset: 8d17cc67a857 Author: emcmanus Date: 2008-10-31 17:34 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/8d17cc67a857 6766173: Spec should say that createMBean wraps a constructor RuntimeException in a RuntimeMBeanException Summary: JMX spec clarification Reviewed-by: dfuchs ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/namespace/MBeanServerSupport.java ! test/javax/management/MBeanServer/MBeanExceptionTest.java Changeset: 2201dad60231 Author: tbell Date: 2008-11-07 11:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/2201dad60231 Merge Changeset: d00c685ae55e Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/jdk/rev/d00c685ae55e Added tag jdk7-b40 for changeset 2201dad60231 ! .hgtags From john.coomes at sun.com Mon Nov 24 16:36:10 2008 From: john.coomes at sun.com (john.coomes at sun.com) Date: Tue, 25 Nov 2008 00:36:10 +0000 Subject: hg: jdk7/hotspot-rt/langtools: 14 new changesets Message-ID: <20081125003632.A3271DB83@hg.openjdk.java.net> Changeset: 6508d7e812e1 Author: mcimadamore Date: 2008-10-23 17:59 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/6508d7e812e1 6732484: Bound error on wildcard code Summary: Check.checkExtends should cope with captured type-variables Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/wildcards/T6732484.java Changeset: 4d2d8b6459e1 Author: mcimadamore Date: 2008-10-23 17:59 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/4d2d8b6459e1 6711619: javac doesn't allow access to protected members in intersection types Summary: Accordingly to new accessibility rules all members of intersection types (but private ones) should be accessible Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/6531090/T6531090b.java + test/tools/javac/generics/6711619/T6711619a.java + test/tools/javac/generics/6711619/T6711619a.out + test/tools/javac/generics/6711619/T6711619b.java + test/tools/javac/generics/6711619/T6711619b.out Changeset: db77bf6adb53 Author: mcimadamore Date: 2008-10-23 18:00 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/db77bf6adb53 6487370: javac incorrectly gives ambiguity warning with override-equivalent abstract inherited methods Summary: Javac should not compare erased return types when checking for ambiguity errors during overload resolution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/6487370/T6487370.java Changeset: 433ee48257c0 Author: mcimadamore Date: 2008-10-23 18:10 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/433ee48257c0 6548436: Incorrect inconvertible types error Summary: Types.rewrite quantifiers should cope with captured type-variables properly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6548436/T6548436a.java + test/tools/javac/cast/6548436/T6548436b.java + test/tools/javac/cast/6548436/T6548436c.java + test/tools/javac/cast/6548436/T6548436d.java Changeset: c6e3fc6dda61 Author: mcimadamore Date: 2008-10-23 18:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/c6e3fc6dda61 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness Summary: Validator.visitTypeApply should substitute all formal typevars with actual parameters Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/T6557954.java Changeset: 5e54a59bcee7 Author: mcimadamore Date: 2008-10-24 12:45 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/5e54a59bcee7 6680106: StackOverFlowError for Cyclic inheritance in TypeParameters with ArrayType Bounds Summary: Javac ends up in an infinite loop while attributing mutually referring array type-parameter bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/typevars/6680106/T6680106.java + test/tools/javac/generics/typevars/6680106/T6680106.out Changeset: a23e1dc02698 Author: mcimadamore Date: 2008-10-24 12:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/a23e1dc02698 6746184: javac fails to compile call to public varargs method Summary: javac's resolution process should go through all steps described in JLS 15.12.2.2 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/varargs/T6746184.java Changeset: ddd75a295501 Author: mcimadamore Date: 2008-10-24 12:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/ddd75a295501 6758789: Some method resolution diagnostic should be improved Summary: Recent work on diagnostics left out some resolution corner cases Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/Formattable.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/6758789/T6758789a.java + test/tools/javac/6758789/T6758789a.out + test/tools/javac/6758789/T6758789b.java + test/tools/javac/6758789/T6758789b.out ! test/tools/javac/generics/inference/6718364/T6718364.out Changeset: 638d45788c9e Author: mcimadamore Date: 2008-10-24 12:46 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/638d45788c9e 6762569: Javac crashes with AssertionError in Types.containedBy Summary: Types.containedBy should be more liberal with UndetVars Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java - test/tools/javac/generics/wildcards/6651719/T6651719b.java + test/tools/javac/generics/wildcards/6762569/T6762569a.java + test/tools/javac/generics/wildcards/6762569/T6762569b.java Changeset: 8d7fa40da0eb Author: tbell Date: 2008-10-24 20:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/8d7fa40da0eb Merge - test/tools/javac/generics/wildcards/6651719/T6651719b.java Changeset: 5ebe90e0afff Author: jjg Date: 2008-10-27 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/5ebe90e0afff 6764226: ListTest fails on javap output with bad characters Reviewed-by: darcy ! test/tools/javap/ListTest.java Changeset: 4f7b344a1ce0 Author: mcimadamore Date: 2008-10-28 14:05 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/4f7b344a1ce0 6763518: Impossible to suppress raw-type warnings Summary: Check.validate(Type) should be invoked after -Xlint is augmented in Attr.visitVarDef Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6304921/T6304921.out + test/tools/javac/warnings/T6763518.java Changeset: 32e309883246 Author: tbell Date: 2008-11-07 11:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/32e309883246 Merge Changeset: 82463d00ac70 Author: xdono Date: 2008-11-20 11:39 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/langtools/rev/82463d00ac70 Added tag jdk7-b40 for changeset 32e309883246 ! .hgtags