Second Code Review for WeakReference leak in the Logging API (6942989)
Daniel D. Daugherty
daniel.daugherty at oracle.com
Mon Jun 21 14:29:59 PDT 2010
David H. and Alan B.,
Since you two were first round code reviewers, it would be good to hear
from you guys on the second round.
It would also be good to hear from you since you had also fixed this
bug in Google's code base.
At this point, I've heard from Eamonn McManus and Tony Printezis on
the second round so I have my required two reviewers, but...
On 6/18/2010 1:25 PM, Daniel D. Daugherty wrote:
> I have a new version of my fix for the WeakReference leak in the
> Logging API done. This version uses ReferenceQueues; thanks to Eamonn
> McManus, Jeremy Manson and Tony Printezis for their insights on using
> ReferenceQueues. Here's a pointer to Tony's paper for background info:
> This version also has limits on the number of dead Loggers that are
> cleaned up per call; thanks to Alan Bateman for politely pushing me in
> that direction.
> The webrev is again relative to OpenJDK7, but the bug is escalated so
> the fix will be backported to the JDK6-Update train. So again, I'll
> need a minimum of two code reviewers.
> Here is the URL for the webrev:
> Thanks, in advance, for any reviews.
More information about the hotspot-runtime-dev