Request for reviews (S): 6934483: GCC 4.5 errors "suggest parentheses around something..." when compiling with -Werror and -Wall
christian.thalinger at oracle.com
Wed Sep 8 01:08:14 PDT 2010
I'm resending this review to this list as I'd like another reviewer.
The original request is here:
On Fri, 2010-03-12 at 12:14 +0000, Andrew John Hughes wrote:
> On 12 March 2010 11:07, Pavel Tisnovsky <ptisnovs at redhat.com> wrote:
> > Hi,
> > please review changes in hotspot source code. Webrev is available at:
> > http://cr.openjdk.java.net/~ptisnovs/Gcc4.5Errors2/
> > These are minor changes fixing compile failure when -Wall -Werror flags are
> > used under gcc 4.5. In this case error message is "suggest parentheses
> > around ...something..."
> > Thanks in advance
> > Pavel Tisnovsky
> HotSpot changes should go to the HotSpot list as I mentioned on the last patch.
6934483: GCC 4.5 errors "suggest parentheses around something..." when
compiling with -Werror and -Wall
And the changes look good.
More information about the hotspot-runtime-dev