Code Review Request for MacOS X build change (7117748)
swingler at apple.com
Sun Dec 4 08:43:03 PST 2011
On Dec 3, 2011, at 8:13 PM, Daniel D. Daugherty wrote:
> I have a fix that allows HSX-23 to be built on MacOS X via JPRT
> without specifying SA_APPLE_BOOT_JAVA or ALWAYS_PASS_TEST_GAMMA
> on the command line. I'm targeting this fix at RT_Baseline for
> the HSX-23-B08 snapshot.
> Here is the webrev URL:
> I tested this fix with the default JPRT boot JDK (JDK6 from Apple)
> and with JDK7 boot JDK (JDK7 bits from Oracle).
> Thanks, in advance, for any reviews.
My concern is that you are skipping the gamma checks in the case when OpenJDK is being built with OpenJDK on the Mac. The gamma tests (and the SA_CLASSPATH) logic only needs to be adjusted when you are building OpenJDK with Apple's Java SE 6.
I like the general direction of these fixes, but could you conditionalize the logic so that these hacky patches only get set when the current bootstrap Java is 1.6?
More information about the hotspot-runtime-dev