Request for review: 7112308 Fix Visual Studio build for precompiled header
Daniel D. Daugherty
daniel.daugherty at oracle.com
Fri Nov 18 06:48:49 PST 2011
I think this is one of the few cases where a push to Main_Baseline
would be warranted. Particularly since more folks are starting to
use Visual Studio (again...)
> Thanks for the review Bengt,
> feel free to push it for me as I don't have the right role to do so.
> On Nov 18, 2011, at 9:17 AM, Bengt Rutisson wrote:
>> Thanks for finding this! Your fix looks good. Just verified a Visual Studio build with your changes applied. Works fine.
> I'll give credit to Karen who filed the bug.
>> I assume you need this in hotspot-rt as soon as possible. But I anyway just want to ask if there is any chance of pushing this through hotspot-gc instead?
>> Tony integrated hotspot-gc and hotspot-main yesterday. That integration brought your original precompiled.hpp change over to hotspot-gc. So, up until now I have not had any problems with my VS projects. Now I guess they will be broken until your new change has propagated from hotspot-rt to hotspot-gc...
>> But if you need it in hotspot-rt you will have the same issue. So there is really no good solution. Just thought I'd ask.
>> On 2011-11-17 16:04, Rickard Bäckman wrote:
>>> Hi All,
>>> my move of the precompiled header broke the project file creation for Visual Studio. Here is a small fix to the problem:
>>> 7112308: Fix Visual Studio build for precompiled header
More information about the hotspot-runtime-dev