Request for review (S): 7100935: win32: memmove is not atomic but is used for pd_conjoint_*_atomic operations
vladimir.kozlov at oracle.com
Tue Oct 18 11:40:07 PDT 2011
I think copy code changes look good.
Regression tests need copyright header as other our tests, for example as this
In TestShortArraycopy.java move test's descriptor above class declaration as in
Siebenborn, Axel wrote:
> 7100935: win32: memmove is not atomic but is used for pd_conjoint_*_atomic.
> The fix is to replace the call to memmove by a simple copy loop.
> I made the fix for windows_x86_64 and for sparc.
> I added the tests for copying oops and the copy of short arrays of Volker.
> I did not use the template of my original change.
> However, win compiler would inline the template and so does gcc. It's strange, that Sun's compiler doesn't.
More information about the hotspot-runtime-dev