Request for review (S): 7100935: win32: memmove is not atomic but is used for pd_conjoint_*_atomic operations
axel.siebenborn at sap.com
Tue Oct 18 23:17:28 PDT 2011
I added the header to the tests.
Thanks for reviewing,
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Dienstag, 18. Oktober 2011 20:40
> To: Siebenborn, Axel
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: Request for review (S): 7100935: win32: memmove is not
> atomic but is used for pd_conjoint_*_atomic operations
> I think copy code changes look good.
> Regression tests need copyright header as other our tests, for example
> as this
> Volker's test:
> In TestShortArraycopy.java move test's descriptor above class
> declaration as in
> Siebenborn, Axel wrote:
> > 7100935: win32: memmove is not atomic but is used for
> > http://www.sapjvm.com/as/webrevs/7100935/
> > The fix is to replace the call to memmove by a simple copy loop.
> > I made the fix for windows_x86_64 and for sparc.
> > I added the tests for copying oops and the copy of short arrays of
> > I did not use the template of my original change.
> > However, win compiler would inline the template and so does gcc. It's
> strange, that Sun's compiler doesn't.
> > Axel
More information about the hotspot-runtime-dev