Review Request (S) 8005994: Method annotations are allocated unnecessarily during class file parsing

Karen Kinnear karen.kinnear at
Tue Jan 15 08:58:19 PST 2013


The code looks good. Does serviceability agent correctly handle the conditional availability of the information?


On Jan 15, 2013, at 7:28 AM, Stefan Karlsson wrote:

> HotSpot unnecessarily allocates annotations arrays when they are not needed. This memory regression was introduced when the annotation data structures were changed in the Permgen Removal project.
> This fix:
> 1) reintroduces the old null checks
> 2) adds a null check before creating the newly introduced method type annotations.
> 3) adds a missing null check where the type annotations are used, since they now can be null.
> Testing:
> jprt, jdk_lang and type annotations tests
> thanks,
> StefanK

More information about the hotspot-runtime-dev mailing list