Review Request (S) 8005994: Method annotations are allocated unnecessarily during class file parsing
karen.kinnear at oracle.com
Tue Jan 15 09:40:54 PST 2013
I don't see them either. Thanks for checking.
On Jan 15, 2013, at 12:19 PM, Stefan Karlsson wrote:
> On 15 jan 2013, at 17:58, Karen Kinnear <karen.kinnear at oracle.com> wrote:
>> The code looks good.
>> Does serviceability agent correctly handle the conditional availability of the information?
> I can't find any references to the annotations in the SA code. Did I miss something?
>> On Jan 15, 2013, at 7:28 AM, Stefan Karlsson wrote:
>>> HotSpot unnecessarily allocates annotations arrays when they are not needed. This memory regression was introduced when the annotation data structures were changed in the Permgen Removal project.
>>> This fix:
>>> 1) reintroduces the old null checks
>>> 2) adds a null check before creating the newly introduced method type annotations.
>>> 3) adds a missing null check where the type annotations are used, since they now can be null.
>>> jprt, jdk_lang and type annotations tests
More information about the hotspot-runtime-dev