[PATCH] 8006508 : Wrong frame constructor is called in os_linux_x86.cpp

Jeremy Manson jeremymanson at google.com
Thu Jan 17 10:32:34 PST 2013

As discussed with David last month.  The frame constructor that is
currently getting called in this case fails if NULL is passed as a PC.  The
fix is to call a constructor that does not expect a PC.

Apologies for the lack of a reproducible test case, but it's basically
impossible to reproduce without a very peculiar and platform-dependent
compilation strategy.

# HG changeset patch
# User jeremymanson
# Date 1358447322 28800
# Node ID b155e0a0e6f030aea5fbdf8cd341efcb2f097a76
# Parent  1a3e54283c54aaa8b3437813e8507fbdc966e5b6
8006508 : Wrong frame constructor is called in os_linux_x86.cpp

diff --git a/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
--- a/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
+++ b/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
@@ -189,7 +189,7 @@
                 CAST_FROM_FN_PTR(address, os::current_frame));
   if (os::is_first_C_frame(&myframe)) {
     // stack is not walkable
-    return frame(NULL, NULL, NULL);
+    return frame();
   } else {
     return os::get_sender_for_C_frame(&myframe);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130117/884fa15c/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8006508.patch
Type: application/octet-stream
Size: 702 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20130117/884fa15c/8006508.patch 

More information about the hotspot-runtime-dev mailing list